ActivityResultContract returns RESULT_CANCELED after ActivityNotFoundException [200845664]

Fixed

Bug

Status Update

No update yet.

Description

gm...@gmail.com

created issue #1

Sep 23, 2021 02:29PM

Component used: Activity
Version used: 1.3.1, 1.4.0-alpha02
Devices/Android versions reproduced on: API 21-30

Steps to reproduce:

Create custom contract with non-existing action or package.
Catch ActivityNotFoundException as suggested in the docs.
After getting an exception you also get ActivityResult{resultCode=RESULT_CANCELED, data=null}.

Conceptually this violates generic principle of Java/Kotlin that method can throw exception OR return result, but not both.

Practically this complicates implementing different handling for "app not found" vs "user pressed Back button" scenarios.

I understand that this quirk is inherited form old startActivityForResult() mechanism, but if you're trying to build a better API with contracts, maybe it's time to reconsider it.

Comments

il...@google.com <il...@google.com> #2Sep 23, 2021 04:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

gm...@gmail.com <gm...@gmail.com> #3Sep 23, 2021 08:21PM

Sample project attached. It's really nothing special, I mostly just copy/pasted examples from the docs.

Press the button, and two toasts (logically representing two different scenarios) appear one after another.

Catching ActivityNotFoundException is a recommended way to deal with "no activity can handle the intent" scenario. If I remember correctly, probing with PackageManager was preferred some time ago, but this has changed due to "package visibility" and other restrictions in recent Android versions.

TestActivityResult.zip

105 KB

Download

il...@google.com <il...@google.com> Sep 23, 2021 10:27PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Sep 27, 2021 10:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit c4531c406f3b65d2f84821beaf4c106f22ecebf6
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Sep 23 17:06:56 2021

Don't return a result when throwing

When there is no available activity for a launched
ActivityResultLauncher an ActivityNotFoundException is thrown, but the
underlying startActivityForResult APIs also still return a result with a
RESULT_CANCELLED request code.

We should ensure that when the ActivityResultRegistry's launch throws an
ActivityNotFoundException, we don't also return a result to the
callback.

RelNote: "The `ActivityResultRegistry` will no longer return a result
to the `ActivityResultCallback` when the `launch` call throws any
`Exception`."
Test: added tests
Bug: 200845664

Change-Id: If4f9159bce2edf7f3f0c76e7ff37ce21b05c13ee

M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityResultTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java

https://android-review.googlesource.com/1835917

jb...@google.com <jb...@google.com> #5Sep 28, 2021 04:18PM

Marked as fixed.

This has been fixed internally and will be released following the Activity 1.4.0-beta01 release.

gm...@gmail.com <gm...@gmail.com> #6Sep 28, 2021 06:53PM

Great news, thanks! :)

ra...@gmail.com <ra...@gmail.com> #7Dec 24, 2021 04:35AM

🙂

md...@gmail.com <md...@gmail.com> #8Feb 13, 2022 05:15PM

git@github.com:google/Accessibility-Test-Framework-for-Android.git

gm...@gmail.com <gm...@gmail.com> #9Jul 7, 2022 01:22PM

Unfortunately, the issue still exists in Jetpack Compose, probably because it uses another overload of ActivityResultRegistry.register().

Sample project attached.

Or should I file a new issue for that?

TestActivityResult2.zip

108 KB

Download

jb...@google.com <jb...@google.com> #10Jul 7, 2022 02:22PM

Please file a new issue.

gm...@gmail.com <gm...@gmail.com> #11Jul 7, 2022 09:12PM

Done

b9...@gmail.com <b9...@gmail.com> #12Aug 17, 2022 04:11AM

Because dispatchResult still get called, I found that if next launch invoke immediately, mLaunchedKeys will add new key then dispatch RESULT_CANCELED. More like race condition.

il...@google.com <il...@google.com> #13Oct 18, 2022 08:26PM

Re comment#12 - I don't think I understand exactly what you are getting at - could you file a new issue with a sample project that exhibits this kind of race condition? We'd love to take a closer look at this.