Add lint check for doing attach and detach in the same transaction [200867930]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 23, 2021 12:05AM

As mentioned in https://issuetracker.google.com/173472486, complementary operations now cancel each other out.

We should create a lint warning notifying developers that using attach() and detach() in the same transaction on the same fragment will no longer destroy and recreate the fragment's view like it used to and if they want this behavior they should separate them into two separate transactions.

This bug is only for detecting the same usage, in the future it would be nice if we had two lint rules that specifically address the differences in ordering of these methods (i.e. doing an detach() then attach() vs doing an attach() then detach()).

Comments

ap...@google.com <ap...@google.com> #2Sep 23, 2021 12:19AM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

jb...@google.com <jb...@google.com> #3Sep 23, 2021 12:26AM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.4.0-alpha10 release.

Issue 200867930

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 23, 2021 12:19AM

jb...@google.com <jb...@google.com> #3Sep 23, 2021 12:26AM

Add comment

Issue metadata