Fixed
Status Update
Comments
jo...@jossiwolf.de <jo...@jossiwolf.de> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ma...@google.com <ma...@google.com> #3
From offline chat with Jossi:
Calling show from an effect with a sheet that fills the max height will result in the sheet being fully expanded Waiting for one frame - no difference Two frames - the show call gets cancelled Three frames - the sheet expands to the HALF_EXPANDED state as it's supposed to
nj...@google.com <nj...@google.com>
jo...@google.com <jo...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 082d1fb072944f1cb65e0bb4249e17804d670df0
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Dec 02 13:13:07 2022
Remove ModalBottomSheetLayout expanded anchor when sheet empty
When the sheet is empty, we will now only have a Hidden anchor. This enables passing in empty sheet content if desired by the user.
Relnote: Fixed an issue where ModalBottomSheetLayout would crash if the sheet content was empty. ModalBottomSheetLayout now allows empty sheet content. If the sheet content is empty, it will only have a Hidden state.
Test: modalBottomSheet_anchorsChange_retainsCurrentValue, modalBottomSheet_emptySheet_expandDoesNotAnimate
Bug: b/200980998 , b/216693030
Change-Id: Ic2288017e3c5a80a0951cf136064cca5e2fab7cb
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
https://android-review.googlesource.com/2327674
Branch: androidx-main
commit 082d1fb072944f1cb65e0bb4249e17804d670df0
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Dec 02 13:13:07 2022
Remove ModalBottomSheetLayout expanded anchor when sheet empty
When the sheet is empty, we will now only have a Hidden anchor. This enables passing in empty sheet content if desired by the user.
Relnote: Fixed an issue where ModalBottomSheetLayout would crash if the sheet content was empty. ModalBottomSheetLayout now allows empty sheet content. If the sheet content is empty, it will only have a Hidden state.
Test: modalBottomSheet_anchorsChange_retainsCurrentValue, modalBottomSheet_emptySheet_expandDoesNotAnimate
Bug:
Change-Id: Ic2288017e3c5a80a0951cf136064cca5e2fab7cb
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
jo...@google.com <jo...@google.com>
na...@google.com <na...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.4.0-alpha04
Description
Hia!
When changing a
ModalBottomSheetLayout
'ssheetContent
and then callingModalBottomSheetState#show
directly after (from an effect), the sheet will expand to theEXPANDED
state. It looks like the anchors aren't calculated correctly. You can repro it with this code:The sheet should go to the
HALF_EXPANDED
state instead. I attached a video of the behavior.Is there any workaround that you can think of?