VideoCapture orientation is inconsistent with ImageCapture orientation [201085351]

Fixed

Feature Request

Status Update

No update yet.

Description

pl...@gmail.com

created issue #1

Sep 25, 2021 12:44AM

[FEATURE/USE CASE]

VideoCapture orientation is inconsistent with ImageCapture in the case where Preview orientation is not the same as Device orientation.

For example: if the Device has portrait orientation and the Preview has landscape orientation, VideoCapture (incorrectly) captures a portrait orientation whereas ImageCapture (correctly) captures a landscape orientation.

The same is true if the Device is landscape and the Preview portrait. The behavior is correct and identical for both ImageCapture and VideoCapture if the Device orientation is the same as the Preview orientation.

[NON-SDK INTERFACES USED]

Custom Preview viewer whose configuration depends only on Preview.getResolutionInfo().getCropRect() , Preview.getResolutionInfo().getResolution() , Preview.getResolutionInfo().getRotationDegrees(), and front or back camera.

[ALTERNATIVES CONSIDERED]

Adjusting the value of VideoCapture.setTargetRotation() after bindToLifecycle() has no effect.

[OTHER INFORMATION] Any other relevant information?

Comments

pl...@gmail.com <pl...@gmail.com> #2Sep 25, 2021 12:49AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

pl...@gmail.com <pl...@gmail.com> #3Sep 25, 2021 01:06AM

Great! Thanks a lot, I'll look for the live updates soon!

pl...@gmail.com <pl...@gmail.com> #4Sep 28, 2021 02:37AM

Discussed on Google Groups:

https://groups.google.com/a/android.com/g/camerax-developers/c/3qK6b3vjsJ0 There are screenshots and captures there.

Issue confirmed as not implemented (yet?).

le...@google.com <le...@google.com> Sep 29, 2021 01:32AM

Assigned to ca...@google.com.

wu...@google.com <wu...@google.com> Oct 5, 2022 08:41AM

Reassigned to to...@google.com.

le...@google.com <le...@google.com> #5Oct 5, 2022 09:27AM

Reassigned to le...@google.com.

From the discussion and attachment in the link in comment #4, video cropping is required but not related to rotation.

le...@google.com <le...@google.com> #6Oct 6, 2022 03:18AM

Hi Robert,

Sorry for late reply, I am wondering what CameraX APIs do you use to achieve WYSIWYG feature?

Are you using ViewPort API or CameraController API?

pl...@gmail.com <pl...@gmail.com> #7Oct 6, 2022 05:29AM

Wow, I haven't thought about this in almost a year.

Reading prior entries here, I'd answer yes, this would mean video cropping
is requested. And this cropping would be independent of device orientation.
Device orientation was useful for describing the use case that gives rise
to the issue.

The CameraX code is

https://github.com/Android-for-Python/camerax_provider/tree/main/camerax_src/org/kivy/camerax
And yes I know there is a newer CameraX video api that I need to look at
some time.

Code Context: The preview image is not displayed on an Android view class,
it is displayed on a "widget" in a Python GUI package called Kivy, and
Python is 'compiled' for Android and can call Java as needed. From the
point of view of CameraX this is just a different surface provider, but
still a texture. There are a couple of odd looking Callback classes, these
are related to calling Python from Java. None of this is significant for
the issue, but you might find the case unusual - so this paragraph is for
context. The whole thing works really well (this issue aside).

Anyway, type if you have questions, comments....

On Wed, Oct 5, 2022 at 5:18 PM <buganizer-system@google.com> wrote:

- Show quoted text -

le...@google.com <le...@google.com> #8Oct 6, 2022 06:00AM

Thanks for the information! Looks like the code use the ViewPort API to achieve WYSIWYG.

New CameraX Video API will support cropping via ViewPort soon. I will update the release version here once it is done.

le...@google.com <le...@google.com> Oct 11, 2022 01:51AM

Accepted by le...@google.com.

le...@google.com <le...@google.com> #9Oct 17, 2022 01:00AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ddbb478b53a2c0922598c245f770459e686444d5
Author: leo huang <leohuang@google.com>
Date: Tue Sep 6 10:18:58 2022 +0800

[Video] Enable video cropping

Video cropping will be enabled when ViewPort or CameraController API is used.

Relnote: "Support video cropping (WYSIWYG feature) when ViewPort or CameraController API is used."

Bug: 191678894
Bug: 201085351
Test: ./gradlew camera:camera-video:connectedAndroidTest
Change-Id: Ifbba8358a6cdf8562621e67eb96360cc1b567e3f

M camera/camera-video/src/androidTest/java/androidx/camera/video/VideoRecordingTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2207336

le...@google.com <le...@google.com> #10Oct 17, 2022 01:02AM

The feature will be released on 1.3.0-alpha01

na...@google.com <na...@google.com> #11Nov 9, 2022 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-video:1.3.0-alpha01