Crash when starting camera session: abstract method "void androidx.camera.extensions.impl.InitializerImpl$OnExtensionsInitializedCallback.onSuccess()" [201177844]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Sep 27, 2021 12:34PM

Description

I am getting the error

abstract method "void androidx.camera.extensions.impl.InitializerImpl$OnExtensionsInitializedCallback.onSuccess()"

on a lot of devices. It happens when I try to start the CameraX View, but I am not using any extensions - I only use ImageAnalysis.

Unfortunately I cannot reproduce this issue locally to figure out the correct stack trace and exact line of code where this happens - as I have none of the devices available to test this.

Reproducibility

3 of 10

Reproduce

I am using CameraX through React Native.

It can be reproduced like this:

git clone https://github.com/mrousavy/react-native-vision-camera
cd react-native-vision-camera
yarn
cd example
yarn
adb reverse tcp:8081 tcp:8081
yarn start

Then open react-native-vision-camera/example/android in Android studio and hit run.

The error is being thrown somewhere in this code snippet. Unfortunately I don't have a full stacktrace so I can't pinpoint the exact line, but I'm onto that.

CameraX Version

1.1.0-alpha08

Android OS Build Number

9
5.1.1
8.1.0
10
and mostly 11 (RP1A.200720.012.A715FXXU6BUH1)

Device Names

HOT 10 (infinix X682C)
Galaxy A71 (SM-A715F)
Infinix NOTE 10
Galaxy A52
Galaxy S20+
Galaxy S10e
... (see attached screenshot for more)

Screenshot 2021-09-27 at 14.25.22.png

166 KB

View

Download

Comments

ch...@google.com <ch...@google.com> Sep 28, 2021 01:07AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Sep 28, 2021 12:00PM

Assigned to ma...@gmail.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@gmail.com <ma...@gmail.com> #3Sep 28, 2021 01:12PM

Hi charcoalchen!

Thank you for your detailed answer, appreciate that!

I can't believe I missed the part about Proguard, thank you for pointing that out! I added that to my proguard rules file and will roll out a new version to test the change - but I think this can easily be fixed by adding the @DoNotStrip/@Keep annotation from Proguard/AndroidX to onSuccess (and onFailure), no? (or at least their declarations in the InitializerImpl.OnExtensionsInitializedCallback interface)

Do you think the assumption is reasonable or not?

Yes, that's correct.

To clarify a bit more: Yes, the code snippet allows enabling extensions, but I do not enable them in my actual app so the code in my snippet (tryEnableExtension) will never be called, and ExtensionsManager::getExtensionEnabledCameraSelector(...) will never be executed.

However - I do use ExtensionsManager.getInstance(...) to check an extensions availability beforehand (extensionsManager.isExtensionAvailable), that's probably the root cause of the crash.

ch...@google.com <ch...@google.com> Sep 29, 2021 01:25AM

Reassigned to ch...@google.com.

wu...@google.com <wu...@google.com> Sep 29, 2021 08:23AM

Accepted by ch...@google.com.

ap...@google.com <ap...@google.com> #4Sep 30, 2021 09:07AM

Project: platform/frameworks/support
Branch: androidx-main

commit b0ebb200765059684cda45208b4371ec7dc20607
Author: Charcoal Chen <charcoalchen@google.com>
Date: Wed Sep 29 14:32:40 2021

Fixed the AbstractMethodError issue which happens when proguard is enabled

- Catch the AbstractMethodError additionally so that the app can still get a default ExtensionsManager instance and won't crash.
- Add proguard-rules.pro in camera-extensions module
- Enable proguard for the extension test app.

Relnote: "Fixed the AbstractMethodError issue which happens when proguard is enabled."

Bug: 201177844
Test: ./gradlew camera:camera-extensions:build && ./gradlew camera:camera-extensions:connectedAndroidTest && manual test
Change-Id: Iae4688ef953751255c49eff8dfd205a6df226cbc

M camera/camera-extensions/build.gradle
M camera/integration-tests/extensionstestapp/build.gradle
A camera/integration-tests/extensionstestapp/proguard-rules.pro
A camera/camera-extensions/proguard-rules.pro
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionsManager.java

https://android-review.googlesource.com/1839993

ch...@google.com <ch...@google.com> #5Sep 30, 2021 09:10AM

Marked as fixed.

The proguard-rules has been added in https://android-review.googlesource.com/1839993. Please wait for CameraX's next release and have a try. If there is still other issue, please kindly let me know. Thanks.

ma...@gmail.com <ma...@gmail.com> #6Sep 30, 2021 10:30AM

Awesome! Thanks - do you have an estimation of when the next release will happen?

ch...@google.com <ch...@google.com> #7Sep 30, 2021 11:01AM

The next release might happen around the middle of Oct if no accident.

Issue 201177844

Description

Description

Reproducibility

Reproduce

CameraX Version

Android OS Build Number

Device Names

Issue summary

Comments

ch...@google.com <ch...@google.com> Sep 28, 2021 01:07AM

ch...@google.com <ch...@google.com> #2Sep 28, 2021 12:00PM

ma...@gmail.com <ma...@gmail.com> #3Sep 28, 2021 01:12PM

ch...@google.com <ch...@google.com> Sep 29, 2021 01:25AM

wu...@google.com <wu...@google.com> Sep 29, 2021 08:23AM

ap...@google.com <ap...@google.com> #4Sep 30, 2021 09:07AM

ch...@google.com <ch...@google.com> #5Sep 30, 2021 09:10AM

ma...@gmail.com <ma...@gmail.com> #6Sep 30, 2021 10:30AM

ch...@google.com <ch...@google.com> #7Sep 30, 2021 11:01AM

Add comment

Issue metadata