Using Room 2.4.0-alpha's new support for JOIN can create wrong output if classes share a column name [201306012]

Fixed

Bug

Status Update

No update yet.

Description

ju...@appsoluts.de

created issue #1

Sep 28, 2021 09:08AM

Component used: Room
Version used: 2.4.0-alpha04
Devices/Android versions reproduced on: Pixel 3a emulator

Description:

It's not uncommon to have an id column of every database entity. However, the code generated using the new JOIN feature introduced in Room 2.4.0 doesn't have the ability to distinguish between id columns from different entities, which can produce completely wrong results.

I've attached a minimal working AS project. In this I've created a User and a UserComment Room entity and attempt to retrieve a list of all Users mapped to their UserComments. But because both entities contain an id-column, Room gets confused and actually returns a list of Users with ids taken from UserComment.

As I understand it, differentiating columns with the same name is difficult for Room, but this issue makes the new feature much less useful and downright dangerous given how prevalent the name id for the column is.

If it's not possible to fix it, perhaps the Room plugin could generate a warning or error if it picks up duplicate column names. As it stands, Room will just silently create faulty data.

RoomJoinBug.zip

106 KB

Download

Comments

da...@google.com <da...@google.com> #2Sep 28, 2021 03:58PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

el...@google.com <el...@google.com> Sep 29, 2021 04:12PM

Reassigned to el...@google.com.

da...@google.com <da...@google.com> Jan 17, 2022 10:08PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #3May 13, 2022 12:06PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

da...@google.com <da...@google.com> May 13, 2022 12:40PM

Marked as fixed.

[Deleted User] <[Deleted User]> #4Oct 5, 2022 02:15AM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

da...@google.com <da...@google.com> #5Oct 5, 2022 12:17PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

th...@gmail.com <th...@gmail.com> #6Dec 6, 2022 03:35PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

da...@google.com <da...@google.com> #7Dec 7, 2022 06:35PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

ne...@gmail.com <ne...@gmail.com> #8May 29, 2023 02:02PM

Thank you, I'll try it and check.

Message last modified on May 29, 2023 02:10PM

yb...@google.com <yb...@google.com> #9May 30, 2023 04:20AM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.

be...@gmail.com <be...@gmail.com> #10Nov 6, 2023 05:17PM

Also I found there is a post which presents same issue on stackoverflow.

https://stackoverflow.com/questions/68832304/mlkit-translate-sdk-crashes-in-release-build