Nullable destination arguments are wrongly required for deep links [201320030]

Fixed

Bug

Status Update

No update yet.

Description

jp...@gmail.com

created issue #1

Sep 27, 2021 11:25PM

Component used: Navigation

Version used: 2.4.0-alpha09

Devices/Android versions reproduced on: all

As mentioned in this comment and this PR, nullable arguments should no longer be included in the required argument checking. When adding a deep link to a NavDestination nullable arguments are still included in the check.

Comments

il...@google.com <il...@google.com> #2Sep 27, 2021 11:30PM

Assigned to jb...@google.com.

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jp...@gmail.com <jp...@gmail.com> #3Sep 28, 2021 12:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

NavDeepLinkBug.zip

19 MB

Download

jb...@google.com <jb...@google.com> Oct 4, 2021 08:44PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #4Oct 14, 2021 02:28AM

deleted

il...@google.com <il...@google.com> #5Oct 14, 2021 06:07PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ww...@gmail.com <ww...@gmail.com> #6Jun 10, 2023 09:06AM

aighawtqqad

Issue 201320030