Nullable destination arguments are wrongly required for deep links [201320030]

Fixed

Bug

Status Update

No update yet.

Description

jp...@gmail.com

created issue #1

Sep 27, 2021 11:25PM

Component used: Navigation

Version used: 2.4.0-alpha09

Devices/Android versions reproduced on: all

As mentioned in this comment and this PR, nullable arguments should no longer be included in the required argument checking. When adding a deep link to a NavDestination nullable arguments are still included in the check.

Comments

il...@google.com <il...@google.com> #2Sep 27, 2021 11:30PM

Assigned to jb...@google.com.

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

jp...@gmail.com <jp...@gmail.com> #3Sep 28, 2021 12:12AM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

NavDeepLinkBug.zip

19 MB

Download

jb...@google.com <jb...@google.com> Oct 4, 2021 08:44PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #4Oct 14, 2021 02:28AM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

il...@google.com <il...@google.com> #5Oct 14, 2021 06:07PM

Marked as fixed.

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

ww...@gmail.com <ww...@gmail.com> #6Jun 10, 2023 09:06AM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Issue 201320030