Room do not support the icu tokenizer [201753224]

Fixed

Bug

Status Update

No update yet.

Description

df...@gmail.com

created issue #1

Oct 1, 2021 03:28PM

Artifact used : androidx.room:room-compiler:2.3.0

Version used: 2.3.0

Theme used: Theme.MaterialComponents.DayNight

Devices/Android versions reproduced on: OnePlus 9R/Android 11

The sample code is as follows:

@Fts4(contentEntity = RecordData::class, tokenizer = FtsOptions.TOKENIZER_ICU)
@Entity(tableName = "records_fts")
data class RecordFts(
    @ColumnInfo(name = "option_text")
    val optionText: String,
    @ColumnInfo(name = "cost_text")
    val costText: String,
    @ColumnInfo(name = "mark")
    val mark: String
)

20211001-232614@2x.png

26 KB

View

Download

Comments

au...@google.com <au...@google.com> Oct 6, 2021 08:29PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Oct 8, 2021 05:40PM

Thanks - Looks like the JDBC library we use is not compiling SQLite with ICU so the compile-time verification Room has fails to create the table.

ap...@google.com <ap...@google.com> #3Oct 8, 2021 10:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2b549031b896460fe396b674ff377cedafa1fadf
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Oct 08 10:51:48 2021

Treat the ICU tokenizer as custom.

When creating FTS tables don't add the tokenizer and args if user defined it to be ICU since the JDBC library used in Room is not compiled with the -DSQLITE_ENABLE_ICU flag.
See

https://github.com/xerial/sqlite-jdbc/blob/3.36.0/Makefile

Bug: 201753224
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cAT
Relnote: Fix a bug where Room would fail to compile with a SQL error when an FTS entity declared to use the ICU tokenizer.
Change-Id: I00db9e36315f69a872a1498b4f5360ec6b576645

M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/CustomFTSTokenizerTest.java
M room/room-compiler/src/main/kotlin/androidx/room/vo/FtsOptions.kt

https://android-review.googlesource.com/1850662

da...@google.com <da...@google.com> Oct 11, 2021 03:33PM

Marked as fixed.

Issue 201753224

Description

Issue summary

Comments

au...@google.com <au...@google.com> Oct 6, 2021 08:29PM

da...@google.com <da...@google.com> #2Oct 8, 2021 05:40PM

ap...@google.com <ap...@google.com> #3Oct 8, 2021 10:00PM

da...@google.com <da...@google.com> Oct 11, 2021 03:33PM

Add comment

Issue metadata