IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 6993863b2ee3af30294167440e37e811263985fd
Author: Shalom Gibly <sgibly@google.com>
Date:   Fri Nov 19 07:52:10 2021

    Updated Checkbox tests goldens
   
    Bug: 202309440
    Change-Id: Ib07cba28c5b5a0e4a33b60dad744ffaf3ef720d4
    Relnote: N/A

M       compose/material3/material3/checkBox_darkTheme_disabled_indeterminate_cuttlefish.png
M       compose/material/material/checkbox_focus_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_disabled_checked_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_indeterminate_cuttlefish.png
M       compose/material/material/checkbox_disabled_indeterminate_cuttlefish.png
M       compose/material/material/checkbox_animateToChecked_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_checked_cuttlefish.png
M       compose/material/material/checkbox_hover_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_checked_animateToUnchecked_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_unchecked_animateToChecked_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_hover_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_disabled_checked_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_focus_cuttlefish.png
M       compose/material/material/checkbox_disabled_checked_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_focus_cuttlefish.png
M       compose/material/material/checkbox_checked_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_indeterminate_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_checked_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_checked_animateToUnchecked_cuttlefish.png
M       compose/material3/material3/checkBox_darkTheme_hover_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_unchecked_animateToChecked_cuttlefish.png
M       compose/material/material/checkbox_indeterminate_cuttlefish.png
M       compose/material/material/checkbox_animateToUnchecked_cuttlefish.png
M       compose/material3/material3/checkBox_lightTheme_disabled_indeterminate_cuttlefish.png

https://android-review.googlesource.com/1897138

Project: platform/frameworks/support
Branch: androidx-main

commit eaca215555aa1ac0a958379693d7b074b751f6c3
Author: Shalom Gibly <sgibly@google.com>
Date:   Thu Nov 18 13:03:15 2021

    Fixes the inner Checkbox corner radius
   
    Apply a more correct way to compute the inner checkbox corner radius,
    which eliminate an issue where a few pixels are not painted correctly
    around the corners.
   
    Bug: 202309440
    Test: CheckboxTest & CheckboxScreenshotTest
    Relnote: N/A
    Change-Id: I165d1dc0a59b743de64f60238b232406cb5ba727

M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M       compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt

https://android-review.googlesource.com/1897101

Project: platform/frameworks/support
Branch: androidx-main

commit baee4b7a78016b96963a586aa6981de02d700750
Author: Shalom Gibly <sgibly@google.com>
Date:   Mon Nov 22 18:04:59 2021

    Fixes Checkbox issues
   
    - Draw a single round rect in case the checkbox internal color is the
    same as its border color.
    - Fix the checkbox corner radius, which appeared to be rendered as more
    than the spec's 2dp value.
   
    Bug: 175198975, 202309440
    Test: CheckboxTest & CheckboxScreenshotTest
    Relnote: "Fix the corner radius that is applied for Checkboxes"
    Change-Id: I38b03cda11bf28245a3af3d726ddd0bb9cbe8fa6

M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M       compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt

https://android-review.googlesource.com/1900059