Checked checkbox isn't fully filled with the color [202309440]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Oct 6, 2021 09:23PM

Jetpack Compose release version: 1.0.3
Kotlin version: 1.5.30

Steps to Reproduce:

Draw checked CheckBox. CheckBox(checked = true, onCheckedChange = null)
Take a screenshot and zoom it

EXP: the checkbox is filled with the color
ACT: There are tiny pixels at the corners of the checkbox which are not filled with the color

I am able to reproduce this issue on Google Pixel 4 XL (which is 1440x3040 pixels and 537 ppi)

Zoomed screenshot is attached

checkbox_zoomed_dark_theme.jpg

29 KB

View

Download

deleted

0 B

Comments

ni...@gmail.com <ni...@gmail.com> #2Oct 6, 2021 09:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f57b5cbd142016a2d95fd7bf736262049b085aeb
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Nov 09 13:23:07 2020

Move FloatingWindow interface to Kotlin

Converted the FloatingWindow inferface to koltin and added the kotlin
std library dependency to navigation-common.

Test: ./gradlew checkApi
Bug: 172823546

Change-Id: I98af40e5c9bc747d792180990f1654d6353aa4b5

M navigation/navigation-common/build.gradle
M navigation/navigation-common/src/main/java/androidx/navigation/FloatingWindow.kt

https://android-review.googlesource.com/1492738

checkbox_highlight_problem_zoomed_dark_theme.png

95 KB

View

Download

ni...@google.com <ni...@google.com> Oct 18, 2021 01:57PM

Assigned to je...@google.com.

lp...@google.com <lp...@google.com> Nov 5, 2021 03:03PM

Reassigned to ja...@google.com.

lp...@google.com <lp...@google.com> Nov 16, 2021 05:41PM

Reassigned to sg...@google.com.

ap...@google.com <ap...@google.com> #3Nov 19, 2021 05:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit b637fdfd6b937d19d4e419c4bfba9b437af6378c
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 01 16:13:27 2021

Merge Navigation Compose version back into Navigation

Rather than run Navigation Compose as a separate,
parallel project from the other Navigation artifacts,
merge the versions together so that we can better
integrate the artifacts together and leverage new
alpha features.

Test: ./gradlew bOS, ran Studio in FLAN and COMPOSE configs
BUG: 172823546
Change-Id: I139a44d95c91dc3cf2e951225aabbc2581914e95

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/samples/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/build.gradle
M settings.gradle
M testutils/testutils-navigation/build.gradle

https://android-review.googlesource.com/1662999

ap...@google.com <ap...@google.com> #4Nov 19, 2021 05:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 51769b7a8d6d3e2032e45b3ec1e3cfe29e718ab6
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 31 10:59:25 2021

Add routes to NavDestination

This change introduces the concept of a route to NavDestination. A route
is String that defines the path to the Destination. Setting the route on
a NavDestination will replace the any id that was set previously and
adds a deep link to the destination. You can set a route on the
NavDestination programatically, or through xml.

RelNote: "You can now add a route to your NavDestination"
Test: NavDestinationTest
Bug: 172823546

Change-Id: I77daf563f480ae54b9728a78e7696ea96d19f264

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/res-public/values/public_attrs.xml
M navigation/navigation-common/src/main/res/values/attrs.xml

https://android-review.googlesource.com/1660682

sg...@google.com <sg...@google.com> Nov 19, 2021 06:33PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Nov 23, 2021 08:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit df16e2452d8333af236a9e5203b396b98f1056be
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Apr 05 17:19:54 2021

Add routes to NavDestination Kotlin DSL

You can now add a route to your NavDestination when using the Kotlin
DSL.

RelNote: "You can now add a route to your NavDestination via the Kotlin
DSL"
Test: NavDestinationBuilderTest
Bug: 172823546

Change-Id: I1276418c8ca0b22eb420c0be6b97f0a5d41de0f9

M navigation/navigation-common/api/api_lint.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt

https://android-review.googlesource.com/1660683