Checked checkbox isn't fully filled with the color [202309440]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Oct 6, 2021 09:23PM

Jetpack Compose release version: 1.0.3
Kotlin version: 1.5.30

Steps to Reproduce:

Draw checked CheckBox. CheckBox(checked = true, onCheckedChange = null)
Take a screenshot and zoom it

EXP: the checkbox is filled with the color
ACT: There are tiny pixels at the corners of the checkbox which are not filled with the color

I am able to reproduce this issue on Google Pixel 4 XL (which is 1440x3040 pixels and 537 ppi)

Zoomed screenshot is attached

checkbox_zoomed_dark_theme.jpg

29 KB

View

Download

deleted

0 B

Comments

ni...@gmail.com <ni...@gmail.com> #2Oct 6, 2021 09:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

checkbox_highlight_problem_zoomed_dark_theme.png

95 KB

View

Download

ni...@google.com <ni...@google.com> Oct 18, 2021 01:57PM

Assigned to je...@google.com.

lp...@google.com <lp...@google.com> Nov 5, 2021 03:03PM

Reassigned to ja...@google.com.

lp...@google.com <lp...@google.com> Nov 16, 2021 05:41PM

Reassigned to sg...@google.com.

ap...@google.com <ap...@google.com> #3Nov 19, 2021 05:28PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 6993863b2ee3af30294167440e37e811263985fd
Author: Shalom Gibly <sgibly@google.com>
Date: Fri Nov 19 07:52:10 2021

Updated Checkbox tests goldens

Bug: 202309440
Change-Id: Ib07cba28c5b5a0e4a33b60dad744ffaf3ef720d4
Relnote: N/A

M compose/material3/material3/checkBox_darkTheme_disabled_indeterminate_cuttlefish.png
M compose/material/material/checkbox_focus_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_disabled_checked_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_indeterminate_cuttlefish.png
M compose/material/material/checkbox_disabled_indeterminate_cuttlefish.png
M compose/material/material/checkbox_animateToChecked_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_checked_cuttlefish.png
M compose/material/material/checkbox_hover_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_checked_animateToUnchecked_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_unchecked_animateToChecked_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_hover_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_disabled_checked_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_focus_cuttlefish.png
M compose/material/material/checkbox_disabled_checked_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_focus_cuttlefish.png
M compose/material/material/checkbox_checked_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_indeterminate_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_checked_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_checked_animateToUnchecked_cuttlefish.png
M compose/material3/material3/checkBox_darkTheme_hover_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_unchecked_animateToChecked_cuttlefish.png
M compose/material/material/checkbox_indeterminate_cuttlefish.png
M compose/material/material/checkbox_animateToUnchecked_cuttlefish.png
M compose/material3/material3/checkBox_lightTheme_disabled_indeterminate_cuttlefish.png

https://android-review.googlesource.com/1897138

ap...@google.com <ap...@google.com> #4Nov 19, 2021 05:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit eaca215555aa1ac0a958379693d7b074b751f6c3
Author: Shalom Gibly <sgibly@google.com>
Date: Thu Nov 18 13:03:15 2021

Fixes the inner Checkbox corner radius

Apply a more correct way to compute the inner checkbox corner radius,
which eliminate an issue where a few pixels are not painted correctly
around the corners.

Bug: 202309440
Test: CheckboxTest & CheckboxScreenshotTest
Relnote: N/A
Change-Id: I165d1dc0a59b743de64f60238b232406cb5ba727

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt

https://android-review.googlesource.com/1897101

sg...@google.com <sg...@google.com> Nov 19, 2021 06:33PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Nov 23, 2021 08:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit baee4b7a78016b96963a586aa6981de02d700750
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Nov 22 18:04:59 2021

Fixes Checkbox issues

- Draw a single round rect in case the checkbox internal color is the
same as its border color.
- Fix the checkbox corner radius, which appeared to be rendered as more
than the spec's 2dp value.

Bug: 175198975, 202309440
Test: CheckboxTest & CheckboxScreenshotTest
Relnote: "Fix the corner radius that is applied for Checkboxes"
Change-Id: I38b03cda11bf28245a3af3d726ddd0bb9cbe8fa6

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Checkbox.kt

https://android-review.googlesource.com/1900059