StackSampling doesn't work on emulator 29+ [202719335]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Oct 11, 2021 02:03PM

Component used: androidx.benchmark:benchmark-junit4

Version used: 1.1.0-alpha08

Devices/Android versions reproduced on: Android Emulator API 29, 30, 31

Benchmarking performance-samples/BenchmarkSample fails on mentioned devices when using simpleperf sampling (StackSamplingSimpleperf)

testInstrumentationRunnerArgument 'androidx.benchmark.profiling.mode', 'StackSampling'

testInstrumentationRunnerArguments["androidx.benchmark.suppressErrors"] = "EMULATOR,LOW-BATTERY"

On real devices: Pixel 3 API 31 and Samsung SM-F711B API 30 it works fine.

Stacktrace:

java.lang.Error: failed to receive simpleperf start flag
	at androidx.benchmark.simpleperf.ProfileSession.startSimpleperfRecording(ProfileSession.java:368)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:142)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:127)
	at androidx.benchmark.StackSamplingSimpleperf.start(Profiler.kt:206)
	at androidx.benchmark.BenchmarkState.beginRunningStage(BenchmarkState.kt:223)
	at androidx.benchmark.BenchmarkState.startNextRepeat(BenchmarkState.kt:289)
	at androidx.benchmark.BenchmarkState.keepRunningInternal(BenchmarkState.kt:386)
	at com.example.benchmark.AutoBoxingBenchmark.integerAlloc(AutoBoxingBenchmark.kt:85)

Comments

cc...@google.com <cc...@google.com> #2Oct 11, 2021 11:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ya...@google.com <ya...@google.com> #3Oct 12, 2021 05:19PM

Yes, it works. But hardware events like cpu-cycles may not be supported. And cpu-cycles is the default event used (as in

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/RecordOptions.java;l=189).
On emulators, we can use software event cpu-clock to replace cpu-cycles. cpu-clock uses a hrtimer in kernel to count thread time used in nanoseconds.
If you want to support both real devices and emulators, you can always use cpu-clock.

By the way, simpleperf error message can be got from `adb logcat` by filtering simpleperf.

cc...@google.com <cc...@google.com> #4Oct 12, 2021 05:55PM

If cpu cycles is a hardware event, I assume we'd want to use that when possible. Is there any way to check if the emulator I'm running on has support for cpu cycles? If not, we could either check for emulators and always use cpu-clock, or retry with cpu-clock if it fails, though I'd like to avoid waiting on a timeout.

We don't currently have an easy way to check logcat, as we're running the capture entirely on a device (via on-device shell commands).

ya...@google.com <ya...@google.com> #5Oct 12, 2021 06:10PM

The most reliable way is to run `simpleperf list hw`, and see if cpu-cycles is in it.
The other way is to use different methods (like system property) to check if it's an emulator.

cc...@google.com <cc...@google.com> #6Oct 12, 2021 06:23PM

Perfect, thanks!

ap...@google.com <ap...@google.com> #7Nov 10, 2021 07:12PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0ded70b4c6097c0c857dbdd3320b2d52929a6116
Author: Chris Craik <ccraik@google.com>
Date: Tue Nov 09 09:08:38 2021

Use cpu-clock if cpu-cycles hw event not present, fix profiler lifecycle

Test: TrivialKotlinBenchmark (with simpleperf enabled, API 29 + 30)
Test: ./gradlew benchmark:benchmark-common:cC
Fixes: 202719335
Relnote: "Fixes multiple crashes in StackSampling profiling mode on
emulators and non-rooted devices"

Note, emulators tested on locally all had the hw counter available, so
haven't reprod fallback path, just validated hw event list parsing.

Also fixes intersections between profiler and thermal throttle
detection, where simpleperf would be started/stopped multiple times in
a row.

Change-Id: Icdbda7d0659aa07f1bdd47eb1b5234af7e714ce8

M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/ThrottleDetector.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt

https://android-review.googlesource.com/1886304

Issue 202719335