StackSampling doesn't work on emulator 29+ [202719335]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Oct 11, 2021 02:03PM

Component used: androidx.benchmark:benchmark-junit4

Version used: 1.1.0-alpha08

Devices/Android versions reproduced on: Android Emulator API 29, 30, 31

Benchmarking performance-samples/BenchmarkSample fails on mentioned devices when using simpleperf sampling (StackSamplingSimpleperf)

testInstrumentationRunnerArgument 'androidx.benchmark.profiling.mode', 'StackSampling'

testInstrumentationRunnerArguments["androidx.benchmark.suppressErrors"] = "EMULATOR,LOW-BATTERY"

On real devices: Pixel 3 API 31 and Samsung SM-F711B API 30 it works fine.

Stacktrace:

java.lang.Error: failed to receive simpleperf start flag
	at androidx.benchmark.simpleperf.ProfileSession.startSimpleperfRecording(ProfileSession.java:368)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:142)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:127)
	at androidx.benchmark.StackSamplingSimpleperf.start(Profiler.kt:206)
	at androidx.benchmark.BenchmarkState.beginRunningStage(BenchmarkState.kt:223)
	at androidx.benchmark.BenchmarkState.startNextRepeat(BenchmarkState.kt:289)
	at androidx.benchmark.BenchmarkState.keepRunningInternal(BenchmarkState.kt:386)
	at com.example.benchmark.AutoBoxingBenchmark.integerAlloc(AutoBoxingBenchmark.kt:85)

Comments

cc...@google.com <cc...@google.com> #2Oct 11, 2021 11:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ya...@google.com <ya...@google.com> #3Oct 12, 2021 05:19PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

cc...@google.com <cc...@google.com> #4Oct 12, 2021 05:55PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ya...@google.com <ya...@google.com> #5Oct 12, 2021 06:10PM

The most reliable way is to run `simpleperf list hw`, and see if cpu-cycles is in it.
The other way is to use different methods (like system property) to check if it's an emulator.

cc...@google.com <cc...@google.com> #6Oct 12, 2021 06:23PM

Perfect, thanks!

ap...@google.com <ap...@google.com> #7Nov 10, 2021 07:12PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0ded70b4c6097c0c857dbdd3320b2d52929a6116
Author: Chris Craik <ccraik@google.com>
Date: Tue Nov 09 09:08:38 2021

Use cpu-clock if cpu-cycles hw event not present, fix profiler lifecycle

Test: TrivialKotlinBenchmark (with simpleperf enabled, API 29 + 30)
Test: ./gradlew benchmark:benchmark-common:cC
Fixes: 202719335
Relnote: "Fixes multiple crashes in StackSampling profiling mode on
emulators and non-rooted devices"

Note, emulators tested on locally all had the hw counter available, so
haven't reprod fallback path, just validated hw event list parsing.

Also fixes intersections between profiler and thermal throttle
detection, where simpleperf would be started/stopped multiple times in
a row.

Change-Id: Icdbda7d0659aa07f1bdd47eb1b5234af7e714ce8

M benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/ThrottleDetector.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt

https://android-review.googlesource.com/1886304

Issue 202719335