Status Update
No update yet.
Comments
va...@google.com
st...@google.com
ap...@google.com
Regression appears to have been caused by aosp/2758367
ap...@google.com
We should probably update the benchmark to use the new flags to turn off the animations.
st...@google.com
ys...@google.com
Branch: androidx-main
commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023
Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.
We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702
Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc
M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt
ys...@google.com
Looks like the latest changes (aosp/2770702 , aosp/2781074 ) improve performance according to the benchmarks
st...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material:1.3.0-alpha08
st...@google.com
When swiping to dismiss, we trigger an animation and call popWithTransition so that the lifecycle does reached Resumed until the animation has completed (when onTransitionComplete gets called) - see WearNavigator::popBackStack.
The problem is that, if we call navController.popBackStack directly, that is also calling WearNavigator.popBackStack, which in turn calls popWithTransition - but there's no corresponding animation, so onTransitionComplete is not called and the lifecycle never reaches Resumed. Conversely, we should not call pop (without transition) for the case where animation is running, because the lifecycle would become Resumed too early.
ap...@google.com
Branch: androidx-main
commit 4c67987dbc870d8e35d811af15ae3edb36f1c836
Author: stevebower <stevebower@google.com>
Date: Mon Mar 28 14:54:44 2022
Destinations do not reach Lifecycle RESUMED after popping the navigation back stack
Test: androidx.wear.compose.navigation
Bug: 202863359
Change-Id: Iff21b4603fd126120241661e066dfaf294d9c25c
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt
Description
Component used: androidx.wear.compose:compose-navigation
Version used: 1.0.0-alpha07
When using
SwipeDismissableNavHostto navigate, destinations are never reaching theRESUMEDlifecycle state, and are always being capped atSTARTED.It looks like navigation is occurring with
pushWithTransitionandpopWithTransition, but there is no corresponding call tomarkTransitionCompletedto allow the state to reachRESUMED.Can be reproduced withhttps://github.com/android/wear-os-samples/tree/main/ComposeAdvanced