[wear.compose:compose-navigation] SwipeDismissableNavHost destinations never reach lifecycle RESUMED [202863359]

Fixed

Bug

Status Update

No update yet.

Description

va...@google.com

created issue #1

Oct 12, 2021 06:59PM

Component used: androidx.wear.compose:compose-navigation

Version used: 1.0.0-alpha07

When using SwipeDismissableNavHost to navigate, destinations are never reaching the RESUMED lifecycle state, and are always being capped at STARTED.

It looks like navigation is occurring with pushWithTransition and popWithTransition, but there is no corresponding call to markTransitionCompleted to allow the state to reach RESUMED.

Can be reproduced with https://github.com/android/wear-os-samples/tree/main/ComposeAdvanced

Comments

va...@google.com <va...@google.com> Oct 12, 2021 07:02PM

Assigned to st...@google.com.

st...@google.com <st...@google.com> Oct 13, 2021 09:30AM

Accepted by st...@google.com.

ap...@google.com <ap...@google.com> #2Oct 14, 2021 08:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Oct 15, 2021 09:48AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

st...@google.com <st...@google.com> Oct 15, 2021 09:56AM

Marked as fixed.

ys...@google.com <ys...@google.com> #4Mar 24, 2022 05:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Message last modified on Mar 24, 2022 05:37PM

ys...@google.com <ys...@google.com> #5Mar 25, 2022 02:44PM

Shared the repro offline. Steve, do you want me to open a diff bug?

st...@google.com <st...@google.com> #6Mar 25, 2022 03:01PM

Status: Assigned (reopened)

We'll just re-open this one.

st...@google.com <st...@google.com> #7Mar 28, 2022 12:14PM

When swiping to dismiss, we trigger an animation and call popWithTransition so that the lifecycle does reached Resumed until the animation has completed (when onTransitionComplete gets called) - see WearNavigator::popBackStack.

The problem is that, if we call navController.popBackStack directly, that is also calling WearNavigator.popBackStack, which in turn calls popWithTransition - but there's no corresponding animation, so onTransitionComplete is not called and the lifecycle never reaches Resumed. Conversely, we should not call pop (without transition) for the case where animation is running, because the lifecycle would become Resumed too early.

ap...@google.com <ap...@google.com> #8Apr 5, 2022 02:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4c67987dbc870d8e35d811af15ae3edb36f1c836
Author: stevebower <stevebower@google.com>
Date: Mon Mar 28 14:54:44 2022

Destinations do not reach Lifecycle RESUMED after popping the navigation back stack

Test: androidx.wear.compose.navigation
Bug: 202863359
Change-Id: Iff21b4603fd126120241661e066dfaf294d9c25c

M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt

https://android-review.googlesource.com/2046525

st...@google.com <st...@google.com> Apr 6, 2022 09:30AM