[wear.compose:compose-navigation] SwipeDismissableNavHost destinations never reach lifecycle RESUMED [202863359]

Fixed

Bug

Status Update

No update yet.

Description

va...@google.com

created issue #1

Oct 12, 2021 06:59PM

Component used: androidx.wear.compose:compose-navigation

Version used: 1.0.0-alpha07

When using SwipeDismissableNavHost to navigate, destinations are never reaching the RESUMED lifecycle state, and are always being capped at STARTED.

It looks like navigation is occurring with pushWithTransition and popWithTransition, but there is no corresponding call to markTransitionCompleted to allow the state to reach RESUMED.

Can be reproduced with https://github.com/android/wear-os-samples/tree/main/ComposeAdvanced

Comments

va...@google.com <va...@google.com> Oct 12, 2021 07:02PM

Assigned to st...@google.com.

st...@google.com <st...@google.com> Oct 13, 2021 09:30AM

Accepted by st...@google.com.

ap...@google.com <ap...@google.com> #2Oct 14, 2021 08:25PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Oct 15, 2021 09:48AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

st...@google.com <st...@google.com> Oct 15, 2021 09:56AM

Marked as fixed.

ys...@google.com <ys...@google.com> #4Mar 24, 2022 05:37PM

Heads up - I ended up using repeatOnLifecycle(state = Lifecycle.State.STARTED) in some code because repeatOnLifecycle(state = Lifecycle.State.RESUMED) wasn't firing, and Alex mentioned this one.

Will provide a repro offline.

Message last modified on Mar 24, 2022 05:37PM

ys...@google.com <ys...@google.com> #5Mar 25, 2022 02:44PM

Shared the repro offline. Steve, do you want me to open a diff bug?

st...@google.com <st...@google.com> #6Mar 25, 2022 03:01PM

Status: Assigned (reopened)

We'll just re-open this one.

st...@google.com <st...@google.com> #7Mar 28, 2022 12:14PM

When swiping to dismiss, we trigger an animation and call popWithTransition so that the lifecycle does reached Resumed until the animation has completed (when onTransitionComplete gets called) - see WearNavigator::popBackStack.

The problem is that, if we call navController.popBackStack directly, that is also calling WearNavigator.popBackStack, which in turn calls popWithTransition - but there's no corresponding animation, so onTransitionComplete is not called and the lifecycle never reaches Resumed. Conversely, we should not call pop (without transition) for the case where animation is running, because the lifecycle would become Resumed too early.

ap...@google.com <ap...@google.com> #8Apr 5, 2022 02:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4c67987dbc870d8e35d811af15ae3edb36f1c836
Author: stevebower <stevebower@google.com>
Date: Mon Mar 28 14:54:44 2022

Destinations do not reach Lifecycle RESUMED after popping the navigation back stack

Test: androidx.wear.compose.navigation
Bug: 202863359
Change-Id: Iff21b4603fd126120241661e066dfaf294d9c25c

M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt

https://android-review.googlesource.com/2046525

st...@google.com <st...@google.com> Apr 6, 2022 09:30AM