Rare IllegalArgumentException thrown by MediaRouter.removeUserRoute() on some Samsung devices running Android 11 [202931542]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

Oct 13, 2021 03:48PM

Component used: androidx.mediarouter:mediarouter Version used: 1.2.5 Devices/Android versions reproduced on: Samsung / Android 11

I've seen crash below happening on Samsung Android 11 devices (various models). It is fairly rare, as it happened only for 5 users 1 or twice, in an app with lots of users. Maybe it can be worked-around catching IllegalArgumentException.

java.lang.IllegalArgumentException: Bad stream type -1
at android.os.Parcel.createExceptionOrNull(Parcel.java:2389)
at android.os.Parcel.createException(Parcel.java:2369)
at android.os.Parcel.readException(Parcel.java:2352)
at android.os.Parcel.readException(Parcel.java:2294)
at android.media.IAudioService$Stub$Proxy.getDevicesForStream(IAudioService.java:5787)
at android.media.MediaRouter.isAudioPathA2DPStatic(MediaRouter.java:3236)
at android.media.MediaRouter.selectDefaultRouteStatic(MediaRouter.java:1148)
at android.media.MediaRouter.removeRouteStatic(MediaRouter.java:1264)
at android.media.MediaRouter.removeUserRoute(MediaRouter.java:1220)
at androidx.mediarouter.media.MediaRouterJellybean.removeUserRoute(MediaRouterJellybean.java:110)
at androidx.mediarouter.media.SystemMediaRouteProvider$JellybeanImpl.onSyncRouteRemoved(SystemMediaRouteProvider.java:493)
at androidx.mediarouter.media.MediaRouter$GlobalMediaRouter$CallbackHandler.syncWithSystemProvider(MediaRouter.java:3646)
at androidx.mediarouter.media.MediaRouter$GlobalMediaRouter$CallbackHandler.handleMessage(MediaRouter.java:3614)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:247)
at android.app.ActivityThread.main(ActivityThread.java:8618)

Comments

su...@google.com <su...@google.com> #2Oct 14, 2021 07:00AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

su...@google.com <su...@google.com> #3Oct 14, 2021 07:03AM

Reassigned to ba...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

pu...@gmail.com <pu...@gmail.com> #4Oct 29, 2021 02:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

fe...@tv2.no <fe...@tv2.no> #5Feb 4, 2022 08:54AM

The crash seems to be slightly increasing with Android 12. Could this error being handled on MediaRouter library?

pu...@gmail.com <pu...@gmail.com> #6Mar 30, 2022 12:40PM

Still happening more and more. Here's an Android 11 stack trace. Please do something about it, even if it is a Samsung specific bug, as it cannot be worked-around at the app level:

java.lang.IllegalArgumentException: Bad stream type -1
at android.os.Parcel.createExceptionOrNull(Parcel.java:2441)
at android.os.Parcel.createException(Parcel.java:2421)
at android.os.Parcel.readException(Parcel.java:2404)
at android.os.Parcel.readException(Parcel.java:2346)
at android.media.IAudioService$Stub$Proxy.getDevicesForStream(IAudioService.java:6999)
at android.media.MediaRouter.isAudioPathA2DPStatic(MediaRouter.java:3310)
at android.media.MediaRouter.selectDefaultRouteStatic(MediaRouter.java:1172)
at android.media.MediaRouter.removeRouteStatic(MediaRouter.java:1288)
at android.media.MediaRouter.removeUserRoute(MediaRouter.java:1244)
at androidx.mediarouter.media.MediaRouterJellybean.removeUserRoute(MediaRouterJellybean.java:110)
at androidx.mediarouter.media.SystemMediaRouteProvider$JellybeanImpl.onSyncRouteRemoved(SystemMediaRouteProvider.java:493)
at androidx.mediarouter.media.MediaRouter$GlobalMediaRouter$CallbackHandler.syncWithSystemProvider(MediaRouter.java:3654)
at androidx.mediarouter.media.MediaRouter$GlobalMediaRouter$CallbackHandler.handleMessage(MediaRouter.java:3622)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8633)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.audio.AudioService.ensureValidStreamType(AudioService.java:6407)
at com.android.server.audio.AudioService.getDevicesForStream(AudioService.java:6740)
at android.media.IAudioService$Stub.onTransact(IAudioService.java:3157)
at android.os.Binder.execTransactInternal(Binder.java:1215)
at android.os.Binder.execTransact(Binder.java:1179)
android.os.RemoteException: Remote stack trace:
at com.android.server.audio.AudioService.ensureValidStreamType(AudioService.java:6407)
at com.android.server.audio.AudioService.getDevicesForStream(AudioService.java:6740)
at android.media.IAudioService$Stub.onTransact(IAudioService.java:3157)
at android.os.Binder.execTransactInternal(Binder.java:1215)
at android.os.Binder.execTransact(Binder.java:1179)

pu...@gmail.com <pu...@gmail.com> #7Mar 30, 2022 12:42PM

Stack trace above is from a Samsung Android 12 device (not 11 as stated).

sz...@gmail.com <sz...@gmail.com> #8Apr 12, 2022 10:19AM

Have same problem. For now 67 users affected, mostly android 12, 100% samsung

da...@bt.com <da...@bt.com> #9Apr 19, 2022 11:32AM

Seeing the same issue on my app - 100 users in the last 7 days. 100% Samsung phones running Android 12, always when the app is backgrounded, and always when they're casting video to Chromecast.
It'd be great if it could be caught, but ultimately this looks like a Samsung bug.

ba...@google.com <ba...@google.com> Apr 30, 2022 11:47PM

Reassigned to bu...@google.com.

ma...@persgroep.net <ma...@persgroep.net> #10May 4, 2022 06:55AM

I can confirm that we see the exact same behavior in our app when casting. Around 120 users run into this crash each week, which is hurting our crashrate significantly. The key points are all the same:
- 100% Samsung, of which most are of the type Galaxy A52s 5G and Galaxy A51
- 100% Android 12
- 98% App in background

Unfortunately we don't seem to be the ones initiating some sort of action so we can't catch the exception in our application code.

pu...@gmail.com <pu...@gmail.com> #11May 9, 2022 04:18PM

This is happening more and more... Apparently, there does not seem to be an incentive from Google to workaround it in this library probably because "not our problem" (it is a Samsung bug). The only thing we can do is to decompile mediarouter and catch the IllegalArguementException ourselves...

sz...@gmail.com <sz...@gmail.com> #12May 17, 2022 12:45PM

Any chance to fix this in somehow? 200+ users in my app has this error. 100% Samsung 99% - android 12 1% - android 11

pu...@gmail.com <pu...@gmail.com> #13May 19, 2022 01:39PM

I finally patched androidx.mediarouter:mediarouter:1.3.0 with Recaf to catch that pesky IllegalArgumentException:

in androidx.mediarouter.media.MediaRouterJellybean, I changed:

 public static void removeUserRoute(Object routerObj, Object routeObj) {
       ((MediaRouter)routerObj).removeUserRoute((MediaRouter.UserRouteInfo)routeObj);
    }

to:

 public static void removeUserRoute(Object routerObj, Object routeObj) {
        try {
            ((MediaRouter)routerObj).removeUserRoute((MediaRouter.UserRouteInfo)routeObj);
        }
        catch (IllegalArgumentException ex) {
            Log.w(TAG, "android.media.MediaRouter.removeUserRoute() failed with IllegalArgumentException (Samsung Android 12 bug work-around)", ex);
        }
    }

To use it:

download https://bubblesoftapps.com/mediarouter-samsung-fix/mediarouter-samsung-fix-1.3.0.zip
unzip in your .m2/repository folder so you end up having /path/to/.m2/repository/androidx/mediarouter/mediarouter-samsung-fix/
update your build.gradle to use it: replace implementation 'androidx.mediarouter:mediarouter:1.3.0' with implementation 'androidx.mediarouter:mediarouter-samsung-fix:1.3.0'
if you have an AndroidX dependency pulling 'androidx.mediarouter:mediarouter', you will have to exclude it so it does not get in the way (duplicate classes). For example, the cast sdk needs it:

implementation('com.google.android.gms:play-services-cast:21.0.1') {
   // replaced by mediarouter-samsung-fix
   exclude group: 'androidx.mediarouter'
}

ol...@google.com <ol...@google.com> #14May 20, 2022 01:32PM

We have made Samsung aware of this issue. It makes sense for us to catch the exception in the AndroidX MediaRouter library, as per #13, as well.

ap...@google.com <ap...@google.com> #15May 20, 2022 03:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit c3805953951058b509f629980ffad858c7a531ee
Author: Oliver Woodman <olly@google.com>
Date: Fri May 20 13:35:47 2022

Workaround for crash removing user routes.

Test: N/A
Bug: 202931542
Change-Id: Ia25cd716cf2cd48ec298aff04e13751cbcb27d45

M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRouterJellybean.java

https://android-review.googlesource.com/2101700

pu...@gmail.com <pu...@gmail.com> #16May 21, 2022 08:57AM

Thanks for the fix (or rather, work-around) !

ol...@google.com <ol...@google.com> #17Jun 9, 2022 10:09AM

Marked as fixed.

Samsung have a fix for the underlying issue, and will roll it out to their devices in future maintenance releases.

pu...@gmail.com <pu...@gmail.com> #18Jun 9, 2022 10:20AM

Glad to hear that ! Thanks for your report to Samsung, and for Samsung devs to fix it.

bl...@moshikids.com <bl...@moshikids.com> #19Jun 22, 2022 02:02PM

any news on when will a fix for this be released in mediarouter?
Thanks!

ol...@google.com <ol...@google.com> #20Jun 24, 2022 05:00PM

AndroidX MediaRouter 1.3.1 will pick up the fix, and is scheduled for release on July 27th.

bu...@google.com <bu...@google.com> #21Aug 30, 2022 02:45PM