Fixed
Status Update
Comments
di...@google.com <di...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8739fcde521e3f7f92111b7424ab924fb22eed16
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:29:57 2020
RxDataStore.kt, the RxJava wrapper for the core API.
Future cls: 1) RxDataBuilder 2) RxDataMigration
Test: RxDataStoreTest.java
Relnote: There is now a RxJava Wrapper for the core DataStore API. Future updates will include a Builder and RxDataMigrations.
Bug: 170311106
Change-Id: I3e7e099488035cca906b5f6e6de0a387acb5b964
A datastore/datastore-rxjava2/api/current.txt
A datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava2/api/res-current.txt
A datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/build.gradle
A datastore/datastore-rxjava2/src/main/AndroidManifest.xml
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStore.kt
A datastore/datastore-rxjava2/src/test-common/java/androidx/datastore/rxjava2/TestingSerializer.kt
A datastore/datastore-rxjava2/src/test/java/androidx/datastore/rxjava2/RxDataStoreTest.java
M docs-tip-of-tree/build.gradle
M settings.gradle
https://android-review.googlesource.com/1470342
Branch: androidx-master-dev
commit 8739fcde521e3f7f92111b7424ab924fb22eed16
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:29:57 2020
RxDataStore.kt, the RxJava wrapper for the core API.
Future cls: 1) RxDataBuilder 2) RxDataMigration
Test: RxDataStoreTest.java
Relnote: There is now a RxJava Wrapper for the core DataStore API. Future updates will include a Builder and RxDataMigrations.
Bug: 170311106
Change-Id: I3e7e099488035cca906b5f6e6de0a387acb5b964
A datastore/datastore-rxjava2/api/current.txt
A datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava2/api/res-current.txt
A datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/build.gradle
A datastore/datastore-rxjava2/src/main/AndroidManifest.xml
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStore.kt
A datastore/datastore-rxjava2/src/test-common/java/androidx/datastore/rxjava2/TestingSerializer.kt
A datastore/datastore-rxjava2/src/test/java/androidx/datastore/rxjava2/RxDataStoreTest.java
M docs-tip-of-tree/build.gradle
M settings.gradle
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a65952abc062e0b8cde3b291cde64c804b70701c
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:39:49 2020
RxDataStoreBuilder.kt to make constructing DataStores from java easier.
Relnote: Added a builder to make constructing Datastores from java easier.
Test: RxDataStoreBuilderTest
Bug: 170311106
Change-Id: Id2b5a4fdcd166cab45aea92db6e76f9e7814e24f
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/AssertThrows.kt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt
https://android-review.googlesource.com/1470343
Branch: androidx-master-dev
commit a65952abc062e0b8cde3b291cde64c804b70701c
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:39:49 2020
RxDataStoreBuilder.kt to make constructing DataStores from java easier.
Relnote: Added a builder to make constructing Datastores from java easier.
Test: RxDataStoreBuilderTest
Bug: 170311106
Change-Id: Id2b5a4fdcd166cab45aea92db6e76f9e7814e24f
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/AssertThrows.kt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0e34cf4861bfffcd328a07d59fdeb78f7211019c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Nov 30 14:06:48 2020
Modify RxDataStoreBuilder constructors to accept required params.
Test: Modified existing tests.
Bug: 170311106
Relnote: N/A
Change-Id: I7f4190dec2f4f62500818c97f2beb55034774c35
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt
https://android-review.googlesource.com/1513602
Branch: androidx-master-dev
commit 0e34cf4861bfffcd328a07d59fdeb78f7211019c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Nov 30 14:06:48 2020
Modify RxDataStoreBuilder constructors to accept required params.
Test: Modified existing tests.
Bug: 170311106
Relnote: N/A
Change-Id: I7f4190dec2f4f62500818c97f2beb55034774c35
M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt
23...@gmail.com <23...@gmail.com> #5
Comment has been deleted.
di...@google.com <di...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 842f0818490cd3f31806c13bd2c0db681ac67e46
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Dec 11 11:30:24 2020
Split preferencesKey<T> into individual types, e.g. intPreferencesKey, longPreferencesKey, etc.
Test: PreferencesFromJavaTest
Relnote: """ The preferencesKey<T>(name: String): Key<T> method has been removed and replaced with methods specific to each supported type, for example preferencesKey<Int>("int") is now preferencesIntKey("int") """
Bug: 170311106
Change-Id: Ibcfac9cca7c8a3dbf2eaae17bdb8c22a8ce5a9f7
M datastore/datastore-preferences-core/api/current.txt
M datastore/datastore-preferences-core/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-core/api/restricted_current.txt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/Preferences.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesFactory.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesKeys.kt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesSerializer.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferenceDataStoreFactoryTest.kt
A datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesFromJavaTest.java
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesSerializerTest.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreFactoryTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/SharedPreferencesMigration.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/PreferencesDataStoreActivity.kt
https://android-review.googlesource.com/1526348
Branch: androidx-master-dev
commit 842f0818490cd3f31806c13bd2c0db681ac67e46
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Dec 11 11:30:24 2020
Split preferencesKey<T> into individual types, e.g. intPreferencesKey, longPreferencesKey, etc.
Test: PreferencesFromJavaTest
Relnote: """ The preferencesKey<T>(name: String): Key<T> method has been removed and replaced with methods specific to each supported type, for example preferencesKey<Int>("int") is now preferencesIntKey("int") """
Bug: 170311106
Change-Id: Ibcfac9cca7c8a3dbf2eaae17bdb8c22a8ce5a9f7
M datastore/datastore-preferences-core/api/current.txt
M datastore/datastore-preferences-core/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-core/api/restricted_current.txt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/Preferences.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesFactory.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesKeys.kt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesSerializer.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferenceDataStoreFactoryTest.kt
A datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesFromJavaTest.java
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesSerializerTest.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreFactoryTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/SharedPreferencesMigration.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/PreferencesDataStoreActivity.kt
su...@gmail.com <su...@gmail.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 431cd63a24c2b35a543f5b6fda6ec5e088d06b3c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Dec 21 11:42:56 2020
Added datastore-rxjava3 and datastore-preferences-rxjava3.
I just copied the rxjava2 modules and replaced the imports with rxjava3 imports.
Test: Copied over tests from rxjava2 modules.
Relnote: This change adds the datastore-preferences-rxjava2 and datastore-preferences-rxjava3 modules
Bug: 170311106
Change-Id: If253fe05877f22b956cda2e2be27387ae76c9b33
A datastore/datastore-preferences-rxjava3/api/current.txt
A datastore/datastore-preferences-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-preferences-rxjava3/api/res-current.txt
A datastore/datastore-preferences-rxjava3/api/restricted_current.txt
A datastore/datastore-preferences-rxjava3/build.gradle
A datastore/datastore-preferences-rxjava3/src/androidTest/java/androidx/datastore/preferences/rxjava3/RxPreferencesDataStoreBuilderTest.java
A datastore/datastore-preferences-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-preferences-rxjava3/src/main/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreBuilder.kt
A datastore/datastore-rxjava3/api/current.txt
A datastore/datastore-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava3/api/res-current.txt
A datastore/datastore-rxjava3/api/restricted_current.txt
A datastore/datastore-rxjava3/build.gradle
A datastore/datastore-rxjava3/src/androidTest/AndroidManifest.xml
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxSharedPreferencesMigrationTest.java
A datastore/datastore-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataMigration.java
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStore.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStoreBuilder.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxSharedPreferencesMigration.kt
A datastore/datastore-rxjava3/src/test-common/java/androidx/datastore/rxjava3/TestingSerializer.kt
A datastore/datastore-rxjava3/src/test/java/androidx/datastore/rxjava3/RxDataStoreTest.java
M settings.gradle
https://android-review.googlesource.com/1532596
Branch: androidx-main
commit 431cd63a24c2b35a543f5b6fda6ec5e088d06b3c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Dec 21 11:42:56 2020
Added datastore-rxjava3 and datastore-preferences-rxjava3.
I just copied the rxjava2 modules and replaced the imports with rxjava3 imports.
Test: Copied over tests from rxjava2 modules.
Relnote: This change adds the datastore-preferences-rxjava2 and datastore-preferences-rxjava3 modules
Bug: 170311106
Change-Id: If253fe05877f22b956cda2e2be27387ae76c9b33
A datastore/datastore-preferences-rxjava3/api/current.txt
A datastore/datastore-preferences-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-preferences-rxjava3/api/res-current.txt
A datastore/datastore-preferences-rxjava3/api/restricted_current.txt
A datastore/datastore-preferences-rxjava3/build.gradle
A datastore/datastore-preferences-rxjava3/src/androidTest/java/androidx/datastore/preferences/rxjava3/RxPreferencesDataStoreBuilderTest.java
A datastore/datastore-preferences-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-preferences-rxjava3/src/main/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreBuilder.kt
A datastore/datastore-rxjava3/api/current.txt
A datastore/datastore-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava3/api/res-current.txt
A datastore/datastore-rxjava3/api/restricted_current.txt
A datastore/datastore-rxjava3/build.gradle
A datastore/datastore-rxjava3/src/androidTest/AndroidManifest.xml
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxSharedPreferencesMigrationTest.java
A datastore/datastore-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataMigration.java
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStore.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStoreBuilder.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxSharedPreferencesMigration.kt
A datastore/datastore-rxjava3/src/test-common/java/androidx/datastore/rxjava3/TestingSerializer.kt
A datastore/datastore-rxjava3/src/test/java/androidx/datastore/rxjava3/RxDataStoreTest.java
M settings.gradle
Description
Version used: 1.0.0-beta02
Devices/Android versions reproduced on: Android 11 (real and emulator)
Essentially the logic is setup a sample project with a fragment and invoke the windowInfoRepository() method with an activity. That causes the ExtensionWindowBackend.globalInstance to hold on to the activity's context. Perhaps using the application context would be better, but I don't know how the context is used.
For example I am using Kotlin and only do the following to get the window metrics to replace deprecated code in Android 12.
val metrics = activity?.windowInfoRepository()?.currentWindowMetrics?.firstOrNull()?.bounds
Stack trace of the leak:
┬───
│ GC Root: Input or output parameters in native code
│
├─ okio.AsyncTimeout class
│ Leaking: NO (PathClassLoader↓ is not leaking and a class is never leaking)
│ ↓ static AsyncTimeout.$class$classLoader
├─ dalvik.system.PathClassLoader instance
│ Leaking: NO (ExtensionWindowBackend↓ is not leaking and A ClassLoader is
│ never leaking)
│ ↓ ClassLoader.runtimeInternalObjects
├─ java.lang.Object[] array
│ Leaking: NO (ExtensionWindowBackend↓ is not leaking)
│ ↓ Object[].[7701]
├─ androidx.window.layout.ExtensionWindowBackend class
│ Leaking: NO (a class is never leaking)
│ ↓ static ExtensionWindowBackend.globalInstance
│ ~~~~~~~~~~~~~~
├─ androidx.window.layout.ExtensionWindowBackend instance
│ Leaking: UNKNOWN
│ Retaining 125.0 kB in 2848 objects
│ ↓ ExtensionWindowBackend.windowExtension
│ ~~~~~~~~~~~~~~~
├─ androidx.window.layout.SidecarCompat instance
│ Leaking: UNKNOWN
│ Retaining 124.9 kB in 2844 objects
│ ↓ SidecarCompat.sidecar
│ ~~~~~~~
├─ androidx.window.sidecar.SettingsSidecarImpl instance
│ Leaking: UNKNOWN
│ Retaining 124.6 kB in 2832 objects
│ mContext instance of com.example.MyActivity with
│ mDestroyed = true
│ ↓ SettingsSidecarImpl.mContext
│ ~~~~~~~~
╰→ com.example.MyActivity instance
Leaking: YES (ObjectWatcher was watching this because com.example.MyActivity
received Activity#onDestroy() callback and
Activity#mDestroyed is true)
Retaining 115.4 kB in 2676 objects
key = 169cb8aa-ce65-4d85-ad39-a03daaad93f7
watchDurationMillis = 5190
retainedDurationMillis = 190
mApplication instance of com.example.Application
mBase instance of androidx.appcompat.view.ContextThemeWrapper
METADATA
Build.VERSION.SDK_INT: 30
Build.MANUFACTURER: Google
LeakCanary version: 2.7
App process name: com.example.debug
Count of retained yet cleared: 4 KeyedWeakReference instances
Stats: LruCache[maxSize=3000,hits=9130,misses=169317,hitRate=5%]
RandomAccess[bytes=9274118,reads=169317,travel=111728236112,range=42477374,size=
51517143]
Heap dump reason: 18 retained objects, app is visible
Analysis duration: 86480 ms