Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9af8f2c07dae4a97c875d198fb471057e7d57dd8
Author: Chris Craik <ccraik@google.com>
Date: Thu Oct 14 11:22:50 2021
Rename FrameNegativeSlack -> FrameOverrun
Fixes: 203008701
Test: ./gradlew benchmark:benchmark-common:cC benchmark:benchmark-macro:cC
Relnote: "FrameNegativeSlack has been renamed to FrameOverrun to clarify it's meaning - how much the frame went over it's time budget."
Also adds further metric/measurement documentation.
Change-Id: I6c2aa3a408b3cc455bcabcd1479933672f186636
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
https://android-review.googlesource.com/1858287
Branch: androidx-main
commit 9af8f2c07dae4a97c875d198fb471057e7d57dd8
Author: Chris Craik <ccraik@google.com>
Date: Thu Oct 14 11:22:50 2021
Rename FrameNegativeSlack -> FrameOverrun
Fixes: 203008701
Test: ./gradlew benchmark:benchmark-common:cC benchmark:benchmark-macro:cC
Relnote: "FrameNegativeSlack has been renamed to FrameOverrun to clarify it's meaning - how much the frame went over it's time budget."
Also adds further metric/measurement documentation.
Change-Id: I6c2aa3a408b3cc455bcabcd1479933672f186636
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
Description
New name to avoid using "negative" in the metric name (which implies the number should be multiplied by -1), and still maintain lower == better.