Fixed
Status Update
Comments
el...@google.com <el...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit f796782ea16c76f151e7d7635945f2f27c1190a0
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 01:26:40 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setTargetFragment
## Proposed Changes
- Detect calls to `Fragment#setTargetFragment`
## Testing
Test: See `FragmentStrictModeTest#detectSetTargetFragment`
## Issues Fixed
Fixes: 153737745
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/139 .
Resolves #139
Github-Pr-Head-Sha: 89c830c8fe9c487e0dd14087dc99a720496d5c0f
GitOrigin-RevId: e73f51cf62e973d664cdfd8193b830e24e007a7c
Change-Id: I3066e87ed7cfa2bda19089979c722f1efe4103cf
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.java
https://android-review.googlesource.com/1640408
Branch: androidx-main
commit f796782ea16c76f151e7d7635945f2f27c1190a0
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 01:26:40 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setTargetFragment
## Proposed Changes
- Detect calls to `Fragment#setTargetFragment`
## Testing
Test: See `FragmentStrictModeTest#detectSetTargetFragment`
## Issues Fixed
Fixes: 153737745
This is an imported pull request from
Resolves #139
Github-Pr-Head-Sha: 89c830c8fe9c487e0dd14087dc99a720496d5c0f
GitOrigin-RevId: e73f51cf62e973d664cdfd8193b830e24e007a7c
Change-Id: I3066e87ed7cfa2bda19089979c722f1efe4103cf
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.java
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit b97161334cfb168eab219ffc7e2567acc87541e3
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Jun 26 08:24:20 2023
Removing redundant map key validation check in TypeAdapterStore.
Bug: 203008711
Test: QueryMethodProcessorTest.kt
Change-Id: I9f7d9d66107300f38dc5a6045a0ceb58d4fd66e8
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
https://android-review.googlesource.com/2637691
Branch: androidx-main
commit b97161334cfb168eab219ffc7e2567acc87541e3
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Jun 26 08:24:20 2023
Removing redundant map key validation check in TypeAdapterStore.
Bug: 203008711
Test: QueryMethodProcessorTest.kt
Change-Id: I9f7d9d66107300f38dc5a6045a0ceb58d4fd66e8
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit fe15d5474be85cc243a90e2ba27ee68dbbca633a
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Jul 18 11:48:35 2023
Creating the @MapColumn annotation to replace @MapInfo.
This CL adds support for the new @MapColumn annotation which declares which column(s) are used to build a map or multimap return value in a DAO query method. This annotation replaces the @MapInfo annotation and should be used on the type specifically. This CL also deprecates the @MapInfo annotation.
In a follow-up CL, support for LongSparseArray, ArrayMap and IntSparseArray will be added for MapColumn and nested maps return types.
Bug: 203008711
Test: QueryMethodProcessorTest.kt, RawQueryMethodProcessorTest.kt, MultimapQueryTest.kt
Relnote: Creating the `@MapColumn` annotation to replace `@MapInfo`, which is now deprecated.
Change-Id: Ib0305c9ba7c0bd73fd885f22b5fac4f6c90f0b24
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/MusicDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/AmbiguousColumnResolverTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultimapQueryTest.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/room-common/api/current.txt
M room/room-common/api/restricted_current.txt
A room/room-common/src/main/java/androidx/room/MapColumn.kt
M room/room-common/src/main/java/androidx/room/MapInfo.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XAnnotated.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MultimapQueryResultAdapter.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RawQueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/common/input/Page.java
https://android-review.googlesource.com/2663656
Branch: androidx-main
commit fe15d5474be85cc243a90e2ba27ee68dbbca633a
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Jul 18 11:48:35 2023
Creating the @MapColumn annotation to replace @MapInfo.
This CL adds support for the new @MapColumn annotation which declares which column(s) are used to build a map or multimap return value in a DAO query method. This annotation replaces the @MapInfo annotation and should be used on the type specifically. This CL also deprecates the @MapInfo annotation.
In a follow-up CL, support for LongSparseArray, ArrayMap and IntSparseArray will be added for MapColumn and nested maps return types.
Bug: 203008711
Test: QueryMethodProcessorTest.kt, RawQueryMethodProcessorTest.kt, MultimapQueryTest.kt
Relnote: Creating the `@MapColumn` annotation to replace `@MapInfo`, which is now deprecated.
Change-Id: Ib0305c9ba7c0bd73fd885f22b5fac4f6c90f0b24
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/MusicDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/AmbiguousColumnResolverTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultimapQueryTest.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/room-common/api/current.txt
M room/room-common/api/restricted_current.txt
A room/room-common/src/main/java/androidx/room/MapColumn.kt
M room/room-common/src/main/java/androidx/room/MapInfo.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XAnnotated.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MultimapQueryResultAdapter.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RawQueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/common/input/Page.java
na...@google.com <na...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core-testing:1.12.0-rc01
androidx.room:room-common:2.6.0-alpha03
androidx.room:room-compiler:2.6.0-alpha03
androidx.room:room-compiler-processing:2.6.0-alpha03
Description