Fixed
Status Update
No update yet.
Comments
ch...@gmail.com
Hi. Thanks for reporting this. Fixed in alpha-04
lp...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
ch...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f88d94e1063eab5d615586fa118bf96652bb57a6
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Oct 26 15:37:35 2021
Fix NavBackStackEntry initial Lifecycle state
NavBackStackEntry currently relies on its host lifecycle owner to
determine the initial host lifecycle state of the entry. This can cause
issues cause the host state might not reflect the dispatched state, so
we can end up with a scenario where the entry moves to a state before
the NavController's lifecycleObserver has dispatched that state.
We should instead make NavBackStackEntries host lifecycle state rely
directly on NavController's lifecycleObserver's dispatched state. This
sure that the entries lifecycle is always properly in sync.
RelNote: "NavBackStackEntries will not longer be pushed down to
`Lifecycle.State.CREATED` after moving to `Lifecycle.State.STARTED` when
the `NavHost` is added directly to the activity's `setContent()`."
Test: NavHostTest
Bug: 203536683
Change-Id: Ia5ac1c2c7e83f90780dd85187519c08debaa6eca
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-testing/src/main/java/androidx/navigation/testing/TestNavigatorState.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
https://android-review.googlesource.com/1871175
Branch: androidx-main
commit f88d94e1063eab5d615586fa118bf96652bb57a6
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Oct 26 15:37:35 2021
Fix NavBackStackEntry initial Lifecycle state
NavBackStackEntry currently relies on its host lifecycle owner to
determine the initial host lifecycle state of the entry. This can cause
issues cause the host state might not reflect the dispatched state, so
we can end up with a scenario where the entry moves to a state before
the NavController's lifecycleObserver has dispatched that state.
We should instead make NavBackStackEntries host lifecycle state rely
directly on NavController's lifecycleObserver's dispatched state. This
sure that the entries lifecycle is always properly in sync.
RelNote: "NavBackStackEntries will not longer be pushed down to
`Lifecycle.State.CREATED` after moving to `Lifecycle.State.STARTED` when
the `NavHost` is added directly to the activity's `setContent()`."
Test: NavHostTest
Bug: 203536683
Change-Id: Ia5ac1c2c7e83f90780dd85187519c08debaa6eca
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-testing/src/main/java/androidx/navigation/testing/TestNavigatorState.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.4.0-beta02 release.
ch...@gmail.com
Great news! Thanks a lot for such a quick resolution of this bug, looking forward to next release :)
Description
Description has been deleted.