Fixed
Status Update
Comments
ch...@gmail.com <ch...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
lp...@google.com <lp...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
ch...@gmail.com <ch...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit f88d94e1063eab5d615586fa118bf96652bb57a6
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Oct 26 15:37:35 2021
Fix NavBackStackEntry initial Lifecycle state
NavBackStackEntry currently relies on its host lifecycle owner to
determine the initial host lifecycle state of the entry. This can cause
issues cause the host state might not reflect the dispatched state, so
we can end up with a scenario where the entry moves to a state before
the NavController's lifecycleObserver has dispatched that state.
We should instead make NavBackStackEntries host lifecycle state rely
directly on NavController's lifecycleObserver's dispatched state. This
sure that the entries lifecycle is always properly in sync.
RelNote: "NavBackStackEntries will not longer be pushed down to
`Lifecycle.State.CREATED` after moving to `Lifecycle.State.STARTED` when
the `NavHost` is added directly to the activity's `setContent()`."
Test: NavHostTest
Bug: 203536683
Change-Id: Ia5ac1c2c7e83f90780dd85187519c08debaa6eca
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-testing/src/main/java/androidx/navigation/testing/TestNavigatorState.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
https://android-review.googlesource.com/1871175
Branch: androidx-main
commit f88d94e1063eab5d615586fa118bf96652bb57a6
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Oct 26 15:37:35 2021
Fix NavBackStackEntry initial Lifecycle state
NavBackStackEntry currently relies on its host lifecycle owner to
determine the initial host lifecycle state of the entry. This can cause
issues cause the host state might not reflect the dispatched state, so
we can end up with a scenario where the entry moves to a state before
the NavController's lifecycleObserver has dispatched that state.
We should instead make NavBackStackEntries host lifecycle state rely
directly on NavController's lifecycleObserver's dispatched state. This
sure that the entries lifecycle is always properly in sync.
RelNote: "NavBackStackEntries will not longer be pushed down to
`Lifecycle.State.CREATED` after moving to `Lifecycle.State.STARTED` when
the `NavHost` is added directly to the activity's `setContent()`."
Test: NavHostTest
Bug: 203536683
Change-Id: Ia5ac1c2c7e83f90780dd85187519c08debaa6eca
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-testing/src/main/java/androidx/navigation/testing/TestNavigatorState.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
jb...@google.com <jb...@google.com> #7
This has been fixed internally and will be available in the Navigation 2.4.0-beta02
release.
ch...@gmail.com <ch...@gmail.com> #8
Great news! Thanks a lot for such a quick resolution of this bug, looking forward to next release :)
Description
Description has been deleted.