CarAppService memory leak reported by leakcanary [203594731]

Fixed

Bug

Status Update

No update yet.

Description

ky...@mapbox.com

created issue #1

Oct 20, 2021 01:40AM

Android Auto version reproduced on: 1.0.0

Sample project to trigger the issue. hellocar.zip is attached
A bug report https://github.com/square/leakcanary/issues/2191

Copy paste from the leakcanary issue below

I was digging into a leak that I thought was our implementation. But found that a minimal project also receives leaks. It's attached. I'm sharing here because maybe the leakcanary folks recognize this error. I'll share a google issue tracker after posting.

implementation("androidx.car.app:app:1.0.0")
implementation("com.squareup.leakcanary:leakcanary-android:2.7")

Repro steps

open app
run ./desktop_head_unit
close dhu
repeat 2 and 3

LeakTrace information

10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.833 29746 30639 D LeakCanary: HEAP ANALYSIS RESULT
10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.833 29746 30639 D LeakCanary: 1 APPLICATION LEAKS
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: References underlined with "~~~" are likely causes.
10-19 18:23:47.833 29746 30639 D LeakCanary: Learn more at https://squ.re/leaks.
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: 1701 bytes retained by leaking objects
10-19 18:23:47.833 29746 30639 D LeakCanary: Signature: 27a828a15f5634ec1f03e7566ebb7d680ca4d
10-19 18:23:47.833 29746 30639 D LeakCanary: ┬───
10-19 18:23:47.833 29746 30639 D LeakCanary: │ GC Root: Global variable in native code
10-19 18:23:47.833 29746 30639 D LeakCanary: │
10-19 18:23:47.833 29746 30639 D LeakCanary: ├─ androidx.car.app.CarAppService$1 instance
10-19 18:23:47.833 29746 30639 D LeakCanary: │    Leaking: UNKNOWN
10-19 18:23:47.833 29746 30639 D LeakCanary: │    Retaining 528 B in 1 objects
10-19 18:23:47.833 29746 30639 D LeakCanary: │    Anonymous subclass of androidx.car.app.ICarApp$Stub
10-19 18:23:47.833 29746 30639 D LeakCanary: │    this$0 instance of com.mapbox.example.hellocar.MainCarAppService
10-19 18:23:47.833 29746 30639 D LeakCanary: │    ↓ CarAppService$1.this$0
10-19 18:23:47.833 29746 30639 D LeakCanary: │                      ~~~~~~
10-19 18:23:47.833 29746 30639 D LeakCanary: ╰→ com.mapbox.example.hellocar.MainCarAppService instance
10-19 18:23:47.833 29746 30639 D LeakCanary:      Leaking: YES (ObjectWatcher was watching this because com.mapbox.example.hellocar.MainCarAppService received
10-19 18:23:47.833 29746 30639 D LeakCanary:      Service#onDestroy() callback and Service not held by ActivityThread)
10-19 18:23:47.833 29746 30639 D LeakCanary:      Retaining 1.7 kB in 23 objects
10-19 18:23:47.833 29746 30639 D LeakCanary:      key = 96cda5f8-8de4-44ef-b1df-641fbc38868f
10-19 18:23:47.833 29746 30639 D LeakCanary:      watchDurationMillis = 349897
10-19 18:23:47.833 29746 30639 D LeakCanary:      retainedDurationMillis = 344896
10-19 18:23:47.833 29746 30639 D LeakCanary:      mApplication instance of android.app.Application
10-19 18:23:47.833 29746 30639 D LeakCanary:      mBase instance of android.app.ContextImpl
10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.833 29746 30639 D LeakCanary: 0 LIBRARY LEAKS
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: A Library Leak is a leak caused by a known bug in 3rd party code that you do not have control over.
10-19 18:23:47.833 29746 30639 D LeakCanary: See https://square.github.io/leakcanary/fundamentals-how-leakcanary-works/#4-categorizing-leaks
10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.833 29746 30639 D LeakCanary: 0 UNREACHABLE OBJECTS
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: An unreachable object is still in memory but LeakCanary could not find a strong reference path
10-19 18:23:47.833 29746 30639 D LeakCanary: from GC roots.
10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.833 29746 30639 D LeakCanary: METADATA
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: Please include this in bug reports and Stack Overflow questions.
10-19 18:23:47.833 29746 30639 D LeakCanary:
10-19 18:23:47.833 29746 30639 D LeakCanary: Build.VERSION.SDK_INT: 30
10-19 18:23:47.833 29746 30639 D LeakCanary: Build.MANUFACTURER: Google
10-19 18:23:47.833 29746 30639 D LeakCanary: LeakCanary version: 2.7
10-19 18:23:47.833 29746 30639 D LeakCanary: App process name: com.mapbox.example.hellocar
10-19 18:23:47.833 29746 30639 D LeakCanary: Stats: LruCache[maxSize=3000,hits=2200,misses=57518,hitRate=3%]
10-19 18:23:47.833 29746 30639 D LeakCanary: RandomAccess[bytes=2808620,reads=57518,travel=25796092554,range=20186019,size=25983967]
10-19 18:23:47.833 29746 30639 D LeakCanary: Heap dump reason: user request
10-19 18:23:47.833 29746 30639 D LeakCanary: Analysis duration: 2773 ms
10-19 18:23:47.833 29746 30639 D LeakCanary: Heap dump file path: /storage/emulated/0/Download/leakcanary-com.mapbox.example.hellocar/2021-10-19_18-23-43_310.hprof
10-19 18:23:47.833 29746 30639 D LeakCanary: Heap dump timestamp: 1634693027822
10-19 18:23:47.833 29746 30639 D LeakCanary: Heap dump duration: 1328 ms
10-19 18:23:47.833 29746 30639 D LeakCanary: ====================================
10-19 18:23:47.882 29746 29746 D LeakCanary: Watching instance of leakcanary.internal.HeapAnalyzerService (leakcanary.internal.HeapAnalyzerService received Service#onDestroy() callback) with key 26fbb319-5266-4de9-91d0-dd86d03c2918

hellocar.zip

797 KB

Download

Comments

ky...@mapbox.com <ky...@mapbox.com> #2Oct 20, 2021 09:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

sh...@google.com <sh...@google.com> #3Oct 25, 2021 04:12PM

Assigned to sh...@google.com.

Thanks for reporting the issue. We will take a look

sh...@google.com <sh...@google.com> Jan 4, 2022 06:26PM

Accepted by sh...@google.com.

ap...@google.com <ap...@google.com> #4Jan 6, 2022 06:20AM

Project: platform/frameworks/support
Branch: androidx-main

commit 184f18330759bbb16fc480dee3d34dc0259dd457
Author: Billy Lam <shiufai@google.com>
Date: Wed Jan 05 15:02:17 2022

Fixed a memory leak due to the ICarApp binder outliving its parent CarAppService

When the car host unbinds from an app, the ICarApp binder stays around until the
host reference to the binder also gets cleaned up. This often means that the CarAppService
is destroyed first but being held around by the binder being an inner class.

This change makes the binder a static inner class, and we explicitly remove its
reference to the outer CarAppService when the service is destroyed.

Bug: 203594731
Bug: 213378655
Test: Verified with the sample showcase app that a leak is no longer reported
Relnote: Fixed a memory leak in `CarAppService` when the car host unbinds.
Change-Id: I5c9caf05797ea257ef21cbd96dab5fdfbc85a70e

M car/app/app/src/test/java/androidx/car/app/CarAppServiceTest.java
M car/app/app/src/main/java/androidx/car/app/CarAppService.java
M car/app/app-samples/showcase/common/build.gradle

https://android-review.googlesource.com/1926808

sh...@google.com <sh...@google.com> #5Jan 6, 2022 11:27PM

Marked as fixed.

Thanks again for reporting the issue. The fix should be available in the next library release.

ma...@gmail.com <ma...@gmail.com> #6Oct 4, 2022 08:57PM

https://twitter.com/OnepieceVostfrf

https://twitter.com/dbs_vostfr

https://vk.com/@twflix24-one-piece-red-tw

https://vk.com/@cinemajos-avatar-la-voie-de-leau-streaming-vf-en-francais-vostfr-fr

https://issuetracker.google.com/issues/250610583

https://issuetracker.google.com/issues/250609756

https://issuetracker.google.com/issues/250609759

https://issuetracker.google.com/issues/250610272

https://issuetracker.google.com/issues/250610273

https://issuetracker.google.com/issues/250610276

https://issuetracker.google.com/issues/250610278

https://issuetracker.google.com/issues/250610593

https://issuetracker.google.com/issues/250610280

https://issuetracker.google.com/issues/250610923

https://issuetracker.google.com/issues/250610282

https://issuetracker.google.com/issues/250611106

https://issuetracker.google.com/issues/250610598

https://issuetracker.google.com/issues/250611463

https://issuetracker.google.com/issues/250611111

https://issuetracker.google.com/issues/250610933

https://issuetracker.google.com/issues/250610935

https://issuetracker.google.com/issues/250611113

https://issuetracker.google.com/issues/250610937

https://issuetracker.google.com/issues/250611116

https://issuetracker.google.com/issues/250611466

https://issuetracker.google.com/issues/250612724

https://issuetracker.google.com/issues/250612604

https://issuetracker.google.com/issues/250612726

https://issuetracker.google.com/issues/250611471

https://issuetracker.google.com/issues/250177858

https://issuetracker.google.com/issues/250172577

https://www.endezo-it.com/2022/10/the-dark-event-of-indonesian-football.html

https://www.49erssports.com/2022/10/kanjuruhan-tragedy-arema-fc-management.html

https://one-piece-red-full-movie-english.webflow.io/

https://documenter.getpostman.com/view/21828632/2s83tJGAat