Status Update
Comments
al...@gmail.com <al...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
al...@gmail.com <al...@gmail.com> #3
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
al...@gmail.com <al...@gmail.com> #4
se...@google.com <se...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
al...@gmail.com <al...@gmail.com> #6
Thanks for showing that callback. Honestly this whole getForegroundInfoAsync
is still unclear to me--since I'm using RxWorker, I usually create a notification inside createWork
and when the work is ongoing, I display a notification with progress bar via doOnSubscribe
, something like this:
api.doSomeWork()
.doOnSubscribe {
// display notification with progress bar
setForegroundAsync(ForegroundInfo(notificationId, notificationBuilder.build()))
}
So how getForegroundInfoAsync
fits into this, I don't understand. The effect of implementing getForegroundInfoAsync
is that I actually get two notifications, the one that displays a progress bar that's already full, and another one that's actually updated.
Edit: actually never mind, getForegroundInfoAsync
has nothing to do with having two notifs. Just figured it out and getForegroundInfoAsync
is called before createWork
.
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit 4d0b5f22951dd44cd4c4ba646fe5ad7a3e87c280
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Nov 05 17:00:43 2021
RxJava2: RxJava wrapper around getForegroundInfoAsync
Test: RxForegroundInfoTest
bug:203851459
Relnote: "
RxWorker has now `getForegroundInfo` returing`Single` that
can be used instead of `getForegroundInfoAsync` that returns
`ListenableFuture`.
"
Change-Id: I21c91cd5db57e85bf1aaa7e1596e2287ab44675c
M work/work-rxjava2/src/main/java/androidx/work/RxWorker.java
M work/work-rxjava2/build.gradle
M work/work-rxjava2/api/public_plus_experimental_current.txt
M work/work-rxjava2/api/current.txt
M work/work-rxjava2/api/restricted_current.txt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit 66303e797f590d88fd50d1c68caee02c1bfac077
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Nov 05 17:43:16 2021
RxJava3: RxJava wrapper around setForegroundInfoAsync
Test: RxForegroundInfoTest
bug:203851459
Relnote: "
RxWorker now has `setForeground` returning `Completable` that
can be used instead of `setForegroundInfoAsync` that returns
`ListenableFuture`.
"
Change-Id: I992a32849600b8c3bb37fa362e9775bc46a6462b
M work/work-rxjava3/src/main/java/androidx/work/rxjava3/RxWorker.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-rxjava3/api/public_plus_experimental_current.txt
M work/work-rxjava3/api/current.txt
M work/work-rxjava3/api/restricted_current.txt
Description
Description has been deleted.