DESCRIPTION:

The bindToLifecycle sometimes throws an error from an async callback/thread which can't be handled from the main/caller thread. It would be good if the library could have some sort of error reporting API (something like an optional parameter for an interface have a abstract method that can handle a error thrown by the method) or maybe just re-throw any async error(s) to the main thread, such that they can be handled without crashing the app.

One such case could be when an unsupported quality selector is used by the `Recorder` instance which is described in the discussion here. https://groups.google.com/a/android.com/g/camerax-developers/c/0T4Ikif_8_0

STEPS TO REPRODUCE:
1. Use an unsupported video quality for the Recorder object for a given config. (for e.g. on Pixel devices I have tested on, UHD isn't supported for the front camera; just an example to reproduce the issue...any other unsupported case can too be used)
2. Use the Recorder object in a VideoCapture instance.
3. Pass the VideoCapture instance while using the bindToLifecycle.
4. Wrap the bindToLifecycle with try-catch statement.

OBSERVED RESULTS: If the quality is really unsupported, an error is thrown in the async thread/callback that does not get caught by the try-catch statement in the main/caller thread, which eventually causes the app to crash in an that cannot be handled correctly.

EXPECTED RESULTS: The error should be caught by the try-catch statement present in the fourth step of STEPS TO REPRODUCE section (, any changes made by the bindToLifecycle method should safely revert) and the app shouldn't crash unexpectedly.

REPRODUCIBILITY: 100%

ADDITIONAL INFORMATION:

Please include all other possible cases where an error might be thrown by the bindToLifecycle method (sync/async) too.

CODE FRAGMENTS:

To quickly reproduce this issue you'll could use the app I'm working on hardcode and,

1. https://github.com/GrapheneOS/Camera/blob/7ca991ff5021a89883157b9dd9a90e82dfbc8134/app/src/main/java/app/grapheneos/camera/config/CamConfig.kt#L555 and replace videoQuality with QualitySelector.QUALITY_UHD

2. Wrap try-catch around the bindToLifeCycle method (https://github.com/GrapheneOS/Camera/blob/7ca991ff5021a89883157b9dd9a90e82dfbc8134/app/src/main/java/app/grapheneos/camera/config/CamConfig.kt#L603)

3. Run the app

Alternatively, you'll could just copy relevant pieces of code from the repository (https://github.com/GrapheneOS/Camera) to the sample app.

Thanks a lot for your time and patiently going through this.

Issue 204221709

Mentioned issues (1)

Links (8)

Issue metadata