Fix links to enum values [204542372]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

ow...@google.com

created issue #1

Oct 29, 2021 01:55PM

Right now, we do not resolve links to enum values. See SavedStateRegistry.consumeRestoredStateForKey, where ON_CREATE is linked in public docs but not in staging.

Comments

ow...@google.com <ow...@google.com> #2Oct 29, 2021 04:38PM

go/dokka-upstream-bug/2215

ap...@google.com <ap...@google.com> #3Nov 1, 2021 03:09PM

Project: platform/tools/dokka-devsite-plugin
Branch: master

commit 6802d68ea4dcae6a7951fa477a3eb42d8bc05ae7
Author: Owen Gray <owengray@google.com>
Date: Fri Oct 29 09:52:07 2021

Add tests for linking to enum values

Bug: 204542372
Test: adds a test
Change-Id: I8559e9e4661cb70ec1dbd93e74d2424674148808

A testData/linking/docs/reference/kotlin/dokkatest/linking/JavaEnum.html
A testData/linking/docs/reference/kotlin/dokkatest/package-list
A testData/linking/docs/reference/dokkatest/_toc.yaml
A testData/linking/docs/reference/dokkatest/classes.html
M build.gradle.kts
A testData/linking/docs/reference/kotlin/dokkatest/linking/KotlinEnum.html
A testData/linking/docs/reference/dokkatest/package-list
A testData/linking/source/dokkatest/linking/JavaLinker.java
A testData/linking/docs/reference/dokkatest/linking/JavaEnum.html
A testData/linking/docs/reference/kotlin/dokkatest/linking/package-summary.html
A testData/linking/source/dokkatest/linking/package-info.java
A testData/linking/docs/reference/dokkatest/index.html
A testData/linking/docs/reference/dokkatest/linking/JavaLinker.html
A testData/linking/docs/reference/kotlin/dokkatest/linking/JavaLinker.html
A testData/linking/docs/reference/kotlin/dokkatest/classes.html
A testData/linking/source/KotlinEnum.kt
A testData/linking/docs/reference/dokkatest/linking/package-summary.html
M src/test/java/com/google/devsite/integration/BasicTest.kt
A testData/linking/docs/reference/dokkatest/packages.html
A testData/linking/docs/reference/kotlin/dokkatest/packages.html
A testData/linking/docs/reference/kotlin/dokkatest/linking/index.html
A testData/linking/docs/reference/kotlin/dokkatest/index.html
A testData/linking/source/dokkatest/linking/JavaEnum.java
A testData/linking/docs/reference/kotlin/dokkatest/_toc.yaml
A testData/linking/docs/reference/dokkatest/linking/KotlinEnum.html
A testData/linking/docs/reference/dokkatest/linking/index.html
A testData/linking/source/KotlinLinker.kt
A testData/linking/docs/reference/dokkatest/linking/KotlinLinkerKt.html

https://android-review.googlesource.com/1874486

https://goto.google.com/android-sha1/6802d68ea4dcae6a7951fa477a3eb42d8bc05ae7

ow...@google.com <ow...@google.com> Nov 11, 2021 02:58PM

Status: New

ap...@google.com <ap...@google.com> #4Feb 15, 2022 09:27PM

Project: platform/tools/dokka-devsite-plugin
Branch: master

commit e26de46958a5eccbe89931ca8d2a4dd477ba15fd
Author: Andrea Falcone <asfalcone@google.com>
Date: Tue Feb 15 11:01:01 2022

Update to Dokka 1.6.10-dev-146

Fixes package level annotations (applies to RestrictTo)
Allows protected methods
Fixes enum linking

BUG: 165112358
BUG: 199863023
BUG: 204542372
Change-Id: I04441ebf23b46c6983ac88e870187d9cfba53ad8

M testData/paging/docs/reference/androidx/paging/PagingDataAdapter.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentManager.FragmentLifecycleCallbacks.html
M testData/compose/docs/reference/androidx/compose/animation/ExitTransition.html
M testData/compose/docs/reference/androidx/compose/animation/core/AnimationVector.html
M testData/compose/docs/reference/kotlin/androidx/compose/animation/core/AnimationVector.html
M testData/paging/docs/reference/androidx/paging/PagingSource.LoadResult.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentManager.html
M testData/compose/docs/reference/kotlin/androidx/compose/animation/ExitTransition.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/Fragment.html
M testData/restrictTo/docs/reference/kotlin/dokkatest/package-list
D testData/restrictTo/docs/reference/kotlin/dokkatest/restrictto/hidden/package-summary.html
M build.gradle.kts
M testData/fragment/docs/reference/androidx/fragment/app/FragmentTransaction.html
M testData/restrictTo/docs/reference/dokkatest/packages.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentResultOwner.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentPagerAdapter.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentTabHost.html
M testData/compose/docs/reference/kotlin/androidx/compose/runtime/CompositionLocal.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentManager.FragmentLifecycleCallbacks.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentActivity.html
M testData/linking/docs/reference/kotlin/dokkatest/linking/package-summary.html
M testData/paging/docs/reference/kotlin/androidx/paging/PagingDataAdapter.html
M src/test/java/com/google/devsite/testing/ConverterTestBase.kt
M testData/compose/docs/reference/androidx/compose/runtime/AbstractApplier.html
M testData/paging/docs/reference/androidx/paging/PagedListAdapter.html
M testData/fragment/docs/reference/androidx/fragment/app/DialogFragment.html
M testData/compose/docs/reference/kotlin/androidx/compose/foundation/lazy/GridCells.html
M testData/compose/docs/reference/kotlin/androidx/compose/animation/EnterTransition.html
M src/test/java/com/google/devsite/renderer/impl/paths/FilePathProviderTest.kt
M testData/linking/docs/reference/kotlin/dokkatest/linking/JavaLinker.html
M testData/paging/docs/reference/androidx/paging/ItemSnapshotList.html
M testData/compose/docs/reference/androidx/compose/foundation/lazy/GridCells.html
M testData/restrictTo/docs/reference/kotlin/dokkatest/_toc.yaml
M testData/restrictTo/docs/reference/dokkatest/classes.html
M src/test/java/com/google/devsite/renderer/converters/DocTagConverterTest.kt
M testData/compose/docs/reference/androidx/compose/animation/EnterTransition.html
M testData/compose/docs/reference/androidx/compose/runtime/CompositionLocal.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentPagerAdapter.html
M testData/paging/docs/reference/androidx/paging/LoadState.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentStatePagerAdapter.html
D testData/restrictTo/docs/reference/dokkatest/restrictto/hidden/index.html
M testData/compose/docs/reference/kotlin/androidx/compose/runtime/AbstractApplier.html
M testData/paging/docs/reference/kotlin/androidx/paging/PagingSource.LoadResult.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentResultOwner.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentContainerView.html
M testData/paging/docs/reference/kotlin/androidx/paging/ItemSnapshotList.html
M testData/paging/docs/reference/kotlin/androidx/paging/PagedListAdapter.html
D testData/restrictTo/docs/reference/kotlin/dokkatest/restrictto/hidden/index.html
M testData/innerClasses/docs/reference/kotlin/dokkatest/inner/OuterClass.html
D testData/restrictTo/docs/reference/dokkatest/restrictto/hidden/HiddenPackageClass.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentTabHost.html
M testData/paging/docs/reference/kotlin/androidx/paging/PagingSource.LoadParams.html
M testData/paging/docs/reference/androidx/paging/RemoteMediator.MediatorResult.html
M src/test/java/com/google/devsite/renderer/converters/ClasslikeDocumentableConverterTest.kt
M testData/compose/docs/reference/kotlin/androidx/compose/runtime/snapshots/Snapshot.html
M testData/restrictTo/docs/reference/kotlin/dokkatest/packages.html
M testData/paging/docs/reference/kotlin/androidx/paging/LoadState.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentManager.html
M testData/paging/docs/reference/androidx/paging/PagingSource.LoadParams.html
M testData/restrictTo/docs/reference/dokkatest/package-list
M testData/restrictTo/docs/reference/dokkatest/_toc.yaml
M testData/restrictTo/docs/reference/kotlin/dokkatest/classes.html
M testData/innerClasses/docs/reference/dokkatest/inner/OuterClass.html
D testData/restrictTo/docs/reference/dokkatest/restrictto/hidden/package-summary.html
M testData/compose/docs/reference/androidx/compose/runtime/snapshots/SnapshotApplyResult.html
M integration-tests/cli/src/test/resources/config.json
M src/test/java/com/google/devsite/renderer/converters/ModifiersTest.kt
M testData/linking/docs/reference/dokkatest/linking/JavaLinker.html
M testData/fragment/docs/reference/androidx/fragment/app/Fragment.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentActivity.html
M src/test/java/com/google/devsite/testing/IntegrationTestBase.kt
M testData/compose/docs/reference/androidx/compose/runtime/snapshots/Snapshot.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/DialogFragment.html
M testData/fragment/docs/reference/kotlin/androidx/fragment/app/FragmentTransaction.html
M src/test/java/com/google/devsite/renderer/converters/FunctionDocumentableConverterTest.kt
M testData/compose/docs/reference/kotlin/androidx/compose/runtime/snapshots/SnapshotApplyResult.html
M testData/paging/docs/reference/kotlin/androidx/paging/RemoteMediator.MediatorResult.html
D testData/restrictTo/docs/reference/kotlin/dokkatest/restrictto/hidden/HiddenPackageClass.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentStatePagerAdapter.html
M testData/fragment/docs/reference/androidx/fragment/app/FragmentContainerView.html
M testData/linking/docs/reference/dokkatest/linking/KotlinLinkerKt.html

https://android-review.googlesource.com/1985383

as...@google.com <as...@google.com> Feb 15, 2022 09:46PM

Marked as fixed, reassigned to as...@google.com.

Issue 204542372