Feature request: Allow to apply overscroll effect to a different element [204650733]

Fixed

Bug

Status Update

No update yet.

Description

si...@gmail.com

created issue #1

Oct 31, 2021 06:22PM

In the release 1.1.0-beta01 rememberOverScrollController() and Modifier.overScroll() are internal, and overscroll modifier is applied to the same element that has scrollable modifier. While it may be a good default, sometimes elements must be hierarchically outside of scrollable container, but visually belonging to it, like for example collapsible toolbar with nested scroll or some other CoordinatorLayout-like stuff. Because overscroll effect applied only to scrollable container, these elements aren't stretched on android 12+, and it looks weird/wrong (example in attachments).

One of the solutions would be to make overscroll APIs public, and allow to hoist OverScrollController to apply overscroll effect to a different element.

Screen Recording 2021-10-29 at 13.48.37.mov

2.4 MB

Download

Comments

no...@google.com <no...@google.com> Nov 3, 2021 11:10PM

Assigned to co...@google.com.

si...@gmail.com <si...@gmail.com> #2May 30, 2022 12:53PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

Screen Recording 2022-05-30 at 15.48.51.mov

5.3 MB

Download

an...@google.com <an...@google.com> #3May 30, 2022 01:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

si...@gmail.com <si...@gmail.com> #4May 30, 2022 02:07PM

deleted

ap...@google.com <ap...@google.com> #5Jun 7, 2022 12:59AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Jun 8, 2022 02:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2e11ab7513f2bbe0f4e66ba7257c1d5e36327d8d
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Tue Jun 07 20:36:06 2022

Fix for Modifier.vertical[horizontal]Scroll() not setting Modifier.overscroll()

This is required when you provide overscrollEffect into Modifier.scrollable() as otherwise there is not attached anywhere OverscrollEffect with zero size which we try to scroll. This was causing crash because of dividing by zero width/height internally.

Bug: 204650733
Test: new test in ScrollTest
Change-Id: Ibdaca7f30d85bf5d3ab2c67cb7d5b7d6dcb8ada7

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt

https://android-review.googlesource.com/2116811

na...@google.com <na...@google.com> #7Oct 24, 2022 01:37PM

The following release(s) address this bug:

androidx.compose.foundation:foundation:1.3.0

lp...@google.com <lp...@google.com> Jan 30, 2023 05:23PM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #8Nov 1, 2024 05:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

na...@google.com <na...@google.com> #9Nov 13, 2024 06:19PM