Activity leaked after orientation change [204905432]

Fixed

Bug

Status Update

No update yet.

Description

le...@gmail.com

created issue #1

Nov 2, 2021 07:00PM

Component used: androidx.navigation:navigation-compose
Version used: 2.4.0-beta01
Devices/Android versions reproduced on: Emulator (tested on API 24, 28 and 30)

The MainActivity gets leaked after the second time the orientation changes, but only after navigating to a new destination using the navHostController.

A working project where this can be reproduced is available here.

These are the reproduction steps:

Run the app (it will load the FooScreen, that only contains a TopAppBar and a Button).
Click the "Open Bar screen" Button (it will load the BarScreen, that only contains a TopAppBar)
Change the orientation of the device from portrait to landscape
Change the orientation back to portrait

At this point you should see StrictMode complaining about the leak inside the logcat:

2021-11-02 16:23:20.672 31230-31230/com.leinardi.template E/StrictMode: class com.leinardi.template.ui.MainActivity; instances=2; limit=1
    android.os.StrictMode$InstanceCountViolation: class com.leinardi.template.ui.MainActivity; instances=2; limit=1
        at android.os.StrictMode.setClassInstanceLimit(StrictMode.java:1)

The LeakCanary notification should also be visible . This is the LeakCanary log:


┬───
│ GC Root: System class
│
├─ leakcanary.internal.InternalLeakCanary class
│    Leaking: NO (MainActivity↓ is not leaking and a class is never leaking)
│    ↓ static InternalLeakCanary.resumedActivity
├─ com.leinardi.template.ui.MainActivity instance
│    Leaking: NO (Activity#mDestroyed is false)
│    mApplication instance of com.leinardi.template.Template
│    mBase instance of android.app.ContextImpl
│    ↓ MainActivity.navHostController
│                   ~~~~~~~~~~~~~~~~~
├─ androidx.navigation.NavHostController instance
│    Leaking: UNKNOWN
│    Retaining 5.5 kB in 140 objects
│    activity instance of com.leinardi.template.ui.MainActivity with mDestroyed = false
│    context instance of com.leinardi.template.ui.MainActivity with mDestroyed = false
│    lifecycleOwner instance of com.leinardi.template.ui.MainActivity with mDestroyed = false
│    ↓ NavController.viewModel
│                    ~~~~~~~~~
├─ androidx.navigation.NavControllerViewModel instance
│    Leaking: UNKNOWN
│    Retaining 128.4 kB in 2406 objects
│    ↓ NavControllerViewModel.viewModelStores
│                             ~~~~~~~~~~~~~~~
├─ java.util.LinkedHashMap instance
│    Leaking: UNKNOWN
│    Retaining 128.3 kB in 2404 objects
│    ↓ LinkedHashMap.header
│                    ~~~~~~
├─ java.util.LinkedHashMap$LinkedHashMapEntry instance
│    Leaking: UNKNOWN
│    Retaining 32 B in 1 objects
│    ↓ LinkedHashMap$LinkedHashMapEntry.after
│                                       ~~~~~
├─ java.util.LinkedHashMap$LinkedHashMapEntry instance
│    Leaking: UNKNOWN
│    Retaining 127.8 kB in 2389 objects
│    ↓ HashMap$HashMapEntry.value
│                           ~~~~~
├─ androidx.lifecycle.ViewModelStore instance
│    Leaking: UNKNOWN
│    Retaining 127.7 kB in 2388 objects
│    ↓ ViewModelStore.mMap
│                     ~~~~
├─ java.util.HashMap instance
│    Leaking: UNKNOWN
│    Retaining 127.7 kB in 2387 objects
│    ↓ HashMap.table
│              ~~~~~
├─ java.util.HashMap$HashMapEntry[] array
│    Leaking: UNKNOWN
│    Retaining 127.7 kB in 2385 objects
│    ↓ HashMap$HashMapEntry[].[1]
│                             ~~~
├─ java.util.HashMap$HashMapEntry instance
│    Leaking: UNKNOWN
│    Retaining 126.6 kB in 2348 objects
│    ↓ HashMap$HashMapEntry.value
│                           ~~~~~
├─ androidx.navigation.compose.BackStackEntryIdViewModel instance
│    Leaking: UNKNOWN
│    Retaining 126.5 kB in 2347 objects
│    ↓ BackStackEntryIdViewModel.saveableStateHolder
│                                ~~~~~~~~~~~~~~~~~~~
├─ androidx.compose.runtime.saveable.SaveableStateHolderImpl instance
│    Leaking: UNKNOWN
│    Retaining 126.4 kB in 2343 objects
│    ↓ SaveableStateHolderImpl.parentSaveableStateRegistry
│                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~
├─ androidx.compose.ui.platform.DisposableSaveableStateRegistry instance
│    Leaking: UNKNOWN
│    Retaining 125.9 kB in 2321 objects
│    ↓ DisposableSaveableStateRegistry.onDispose
│                                      ~~~~~~~~~
├─ androidx.compose.ui.platform.DisposableSaveableStateRegistry_androidKt$DisposableSaveableStateRegistry$1 instance
│    Leaking: UNKNOWN
│    Retaining 125.6 kB in 2312 objects
│    Anonymous subclass of kotlin.jvm.internal.Lambda
│    ↓ DisposableSaveableStateRegistry_androidKt$DisposableSaveableStateRegistry$1.$androidxRegistry
│                                                                                  ~~~~~~~~~~~~~~~~~
├─ androidx.savedstate.SavedStateRegistry instance
│    Leaking: UNKNOWN
│    Retaining 125.6 kB in 2310 objects
│    ↓ SavedStateRegistry.mComponents
│                         ~~~~~~~~~~~
├─ androidx.arch.core.internal.SafeIterableMap instance
│    Leaking: UNKNOWN
│    Retaining 125.5 kB in 2309 objects
│    ↓ SafeIterableMap.mEnd
│                      ~~~~
├─ androidx.arch.core.internal.SafeIterableMap$Entry instance
│    Leaking: UNKNOWN
│    Retaining 125.3 kB in 2302 objects
│    ↓ SafeIterableMap$Entry.mValue
│                            ~~~~~~
├─ androidx.activity.ComponentActivity$$ExternalSyntheticLambda1 instance
│    Leaking: UNKNOWN
│    Retaining 125.3 kB in 2301 objects
│    f$0 instance of com.leinardi.template.ui.MainActivity with mDestroyed = true
│    ↓ ComponentActivity$$ExternalSyntheticLambda1.f$0
│                                                  ~~~
╰→ com.leinardi.template.ui.MainActivity instance
     Leaking: YES (ObjectWatcher was watching this because com.leinardi.template.ui.MainActivity received
     Activity#onDestroy() callback and Activity#mDestroyed is true)
     Retaining 125.3 kB in 2300 objects
     key = 2c6ea34a-19c0-4d26-a5ec-88625d79531f
     watchDurationMillis = 42581
     retainedDurationMillis = 37580
     mApplication instance of com.leinardi.template.Template
     mBase instance of android.app.ContextImpl
METADATA
Build.VERSION.SDK_INT: 24
Build.MANUFACTURER: Google
LeakCanary version: 2.7
App process name: com.leinardi.template
Stats: LruCache[maxSize=3000,hits=1619,misses=30537,hitRate=5%]
RandomAccess[bytes=1518368,reads=30537,travel=10623307269,range=18917491,size=20769812]
Heap dump reason: user request
Analysis duration: 1249 ms

Things I have noticed:

the leak happens only after the 2nd change of orientation (so, if you start with the phone in portrait, when you go back from landscape to portrait)
the leak happens also on the Debug screen, if I navigate to it using the nav component
the leak does not happen if the Bar screen is accessed via deep link (adb shell am start -d "template://bar" -a android.intent.action.VIEW)
the leak does not happen if use the navigate up button of the top app bar to go back from Bar screen to Foo screen (Foo screen never leaks)
reproducible on API level 24, 28 and 30 (I did not test on other levels)

I've also tried to use the Android Studio Profiled to investigate the leak, but I wasn't really successful. Here some screenshots:

Profiler 1 Profiler 1

This is the overview of the modules of the repro project: enter image description here

In short, the App only has the single Activity with no logic beside setting up the nav host. The navigation logic is inside the core-navigation. Each feature module provides UI and business logic. Currently there are 3 features with 1 screen each: Foo, Bar and Debug. Foo screen has only one button that leads to Bar screen. The leak happens inside Bar screen, if you rotate the device twice. It does not happen if you access Bar via Deeplink.

Comments

le...@gmail.com <le...@gmail.com> #2Nov 4, 2021 06:27PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

il...@google.com <il...@google.com> Nov 10, 2021 12:43AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Nov 12, 2021 12:08AM

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

jb...@google.com <jb...@google.com> #4Nov 12, 2021 01:08AM

Marked as fixed.

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

Issue 204905432