[Material3] Add progress indicators [205023841]

Fixed

Feature Request

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Nov 4, 2021 02:56AM

Currently the Compose Material3 library is missing linear/circular progress indicators. They should be added as a replacement for the Material2 component

Comments

no...@google.com <no...@google.com> Nov 5, 2021 11:08PM

Assigned to je...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Nov 11, 2021 04:21AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

co...@google.com <co...@google.com> Nov 23, 2021 05:31PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #3Dec 21, 2021 09:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit da5e5de89a482161f7bd1ce431bc658ce49a036f
Author: Max Ying <maxying@google.com>
Date: Tue Dec 14 14:37:15 2021

Add component tokens for progress indicators.

Bug:

b/205023841

Test: manual
Change-Id: I6b20ca478870ed16cf10af09a885c9501ec5c415

A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/LinearProgressIndicatorTokens.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/CircularProgressIndicatorTokens.kt

https://android-review.googlesource.com/1922997

co...@google.com <co...@google.com> Dec 22, 2021 04:01PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Jan 11, 2022 06:30PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 19b90354bac62c8f9230d92f34955dc8aa4e1072
Author: Max Ying <maxying@google.com>
Date: Wed Jan 05 07:18:37 2022

Add scuba goldens for progress indicators.

Bug:

b/205023841

Change-Id: Iefdc8229b48219415d1b7bcee459f8ff4c4d0e2f

A compose/material3/material3/circularProgressIndicator_lightTheme_definite_cuttlefish.png
A compose/material3/material3/circularProgressIndicator_lightTheme_indefinite_cuttlefish.png
A compose/material3/material3/circularProgressIndicator_darkTheme_definite_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_lightTheme_indefinite_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_lightTheme_definite_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_darkTheme_definite_cuttlefish.png

https://android-review.googlesource.com/1937197

ap...@google.com <ap...@google.com> #5Jan 11, 2022 06:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit befe7ae8ac7f25caba6e81e88d2d4689f79013e2
Author: Max Ying <maxying@google.com>
Date: Tue Jan 04 14:58:28 2022

Add progress indicators, samples, and tests.

Bug:

b/205023841

Test: ProgressIndicatorTest.kt, ProgressIndicatorScreenshotTest.kt
Relnote: Added support for Material 3 progress indicators.
Change-Id: Iff232ace50948f646ca8e7586343dba163628418

M compose/material3/material3/api/restricted_current.txt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Components.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ProgressIndicatorTest.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ProgressIndicatorScreenshotTest.kt
A compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/ProgressIndicatorSamples.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1931857

ma...@google.com <ma...@google.com> Jan 18, 2022 06:12PM

Marked as fixed.

Issue 205023841

Description

Issue summary

Comments

no...@google.com <no...@google.com> Nov 5, 2021 11:08PM

ma...@gmail.com <ma...@gmail.com> #2Nov 11, 2021 04:21AM

co...@google.com <co...@google.com> Nov 23, 2021 05:31PM

ap...@google.com <ap...@google.com> #3Dec 21, 2021 09:37PM

co...@google.com <co...@google.com> Dec 22, 2021 04:01PM

ap...@google.com <ap...@google.com> #4Jan 11, 2022 06:30PM

ap...@google.com <ap...@google.com> #5Jan 11, 2022 06:30PM

ma...@google.com <ma...@google.com> Jan 18, 2022 06:12PM

Add comment

Issue metadata