Issue with recording video with Pixel 1 [205340278]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Nov 6, 2021 10:43PM

The preview starts behaving abnormally while recording starts in 16:9 on a Pixel 1. Random color lines just randomly flash on the phone screen.

Here's a recording of this issue: https://matrix-client.matrix.org/_matrix/media/r0/download/matrix.org/dCaWZuidryOOHNCsBTPJEpjb

To quickly test the camera app, here's the link to the repository of our open-source camera app: https://github.com/GrapheneOS/Camera (The apk can be obtained from the releases section too [present in the right column])

Thanks a lot for the help and support!

Regards, Mohit

Comments

fu...@google.com <fu...@google.com> Nov 8, 2021 09:55PM

Reassigned to tr...@google.com.

wu...@google.com <wu...@google.com> Nov 9, 2021 03:42AM

Reassigned to le...@google.com.

sc...@google.com <sc...@google.com> Nov 17, 2021 08:31AM

Accepted by le...@google.com.

ap...@google.com <ap...@google.com> #2Nov 17, 2021 09:14AM

Project: platform/frameworks/support
Branch: androidx-main

commit 627275a37e4dbf1b27726ffb4157c736552499bb
Author: leo huang <leohuang@google.com>
Date: Tue Nov 16 00:37:48 2021

Fix Preview color line issue when recording UHD video on Pixel1

This should be a camera HAL issue and can be workaround by putting Preview surface in front of MediaCodec surface when creating CameraCaptureSession.
The solution applies the workaround to all devices since we want to avoid some other devices which have the same quirk. Besides, the workaround does not cost much performance and should be safe to apply.

Relnote: "Fixed Preview will have interlaced color lines after start UHD video recording on Pixel1."

Bug: 205340278
Test: Manually testing
Change-Id: I833c65d48e5a050742b4d1b4f2c4a851563c87c4

M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/SurfaceOrderQuirk.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/SurfaceSorterTest.kt

https://android-review.googlesource.com/1892815

sh...@gmail.com <sh...@gmail.com> #3Nov 17, 2021 12:43PM

Hi,

Glad to know that this issue has now been fixed.

Thanks a lot for fixing this issue (Leo) and informing about the status of this issue (Scott)!

Regards, Mohit

le...@google.com <le...@google.com> #4Nov 17, 2021 05:49PM

Marked as fixed.

Thanks for reporting this bug. The solution will be included in CameraX 1.1.0-alpha12 release.

The release status can also be tracked on https://developer.android.com/jetpack/androidx/releases/camera.

ap...@google.com <ap...@google.com> #5Nov 28, 2021 08:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit 559b1229074e25008a777b9208c97cadfda57a14
Author: leo huang <leohuang@google.com>
Date: Wed Nov 24 19:54:08 2021

Fix Preview color line issue when recording UHD video on Pixel1

aosp/1892815 only can fix Preview + VideoCapture, but Preview + ImageCapture + VideoCapture has the same problem when ImageCapture surface is in front of Preview surface while creating CameraCaptureSession. The workaround put Preview in front of both ImageCapture and VideoCapture.

Bug: 205340278
Test: Manually testing
Change-Id: Id215db3fe726adc6e0a320bbcc860fbcb6d14c13

M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/SurfaceOrderQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/SurfaceSorter.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/SurfaceSorterTest.kt

https://android-review.googlesource.com/1901413