Fixed
Status Update
No update yet.
Comments
wu...@google.com
wu...@google.com
sc...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
sh...@gmail.com
Great! Thanks a lot, I'll look for the live updates soon!
sc...@google.com
sh...@gmail.com
Hi Scott,
Not sure if the latest release had the changes (please feel free to ignore this just in case if it didn't), but the issue with auto-flash doesn't seem to be fixed for Pixel 3a.
The first flash is performed, however the second flash that introduces light to the output image isn't flashed/performed (in auto flash mode; works fine in manual/always flash mode).
Thanks a lot for the help and support!
Regards, Mohit
sc...@google.com
Hi Mohit, The latest release doesn't contain the fix yet. Next release should have it .
sh...@gmail.com
Hi Scott,
Glad to know that the release would have the fix.
Thanks a lot for the update.
Regards, Mohit
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 2c3288a7c217e977dd81e098daa18b4470e70d4c
Author: repo sync -c -j8 <scottnien@google.com>
Date: Fri Nov 19 17:47:53 2021
Fixed the issue that cannot get bright photos when flash is auto on Pixel 3a / Pixel 3a XL
On the devices that cannot get bright photos when flash is auto,
set AE_MODE to AE_MODE_ON_ALWAYS_FLASH in still capture request
to workaround it.
Bug: 205373142
Test: UseFlashOnForAutoFlashTest
Relnote: "Fixed the issue that captured photos in FLASH_AUTO mode
is underexposured in dark conditions on Pixel 3a and Pixel 3a XL"
Change-Id: I13f19d787a770b4757ce6f80783aadf586d5c5b7
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraNoResponseWhenEnablingFlashQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/SamsungPreviewTargetAspectRatioQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/Camera2CameraControlImplTest.kt
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/OverrideAeModeForStillCaptureTest.kt
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirkTest.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraControlImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/Nexus4AndroidLTargetAspectRatioQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/OverrideAeModeForStillCapture.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CrashWhenTakingPhotoWithAutoFlashAEModeQuirk.java
https://android-review.googlesource.com/1894942
Branch: androidx-main
commit 2c3288a7c217e977dd81e098daa18b4470e70d4c
Author: repo sync -c -j8 <scottnien@google.com>
Date: Fri Nov 19 17:47:53 2021
Fixed the issue that cannot get bright photos when flash is auto on Pixel 3a / Pixel 3a XL
On the devices that cannot get bright photos when flash is auto,
set AE_MODE to AE_MODE_ON_ALWAYS_FLASH in still capture request
to workaround it.
Bug: 205373142
Test: UseFlashOnForAutoFlashTest
Relnote: "Fixed the issue that captured photos in FLASH_AUTO mode
is underexposured in dark conditions on Pixel 3a and Pixel 3a XL"
Change-Id: I13f19d787a770b4757ce6f80783aadf586d5c5b7
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraNoResponseWhenEnablingFlashQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/SamsungPreviewTargetAspectRatioQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/Camera2CameraControlImplTest.kt
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/OverrideAeModeForStillCaptureTest.kt
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirkTest.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraControlImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/Nexus4AndroidLTargetAspectRatioQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/OverrideAeModeForStillCapture.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CrashWhenTakingPhotoWithAutoFlashAEModeQuirk.java
sh...@gmail.com
Hey Scott,
Thanks a lot for fixing this issue!
Regards, Mohit
Description
On Pixel 3a, setting flash to automatic results in dark photographs, as the second flash to light the scene doesn't trigger.
Setting flash to manually on and taking a photo will have a long flash for the autofocus to work, then a second shorter flash as the photo is taken.
Setting flash to auto and being somewhere dark enough to require the flash will have a long flash for the autofocus, but not then trigger the second flash whilst the photo is taken, resulting in a dark picture.
To test/debug this issue you'll could use our CameraX based app (releases section) on a Pixel 3a:https://github.com/GrapheneOS/Camera
Thanks a lot for all the help and support.
Regards, Mohit