Fixed
Status Update
Comments
je...@google.com <je...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
po...@google.com <po...@google.com>
ad...@google.com <ad...@google.com>
ap...@google.com <ap...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
Description
Currently,
Modifier.composed { /*code*/ } != Modifier.composed { /*same code*/ }
, which can lead to unexpected results in some cases.For example,
Modifier.testTag("tag")
is inferred to be static, butModifier.testTag("tag") != Modifier.testTag("tag")
, which will make a difference when Live Literals is enabled.To fix this, we need to implement
ComposedModifier.equals()
, which is not possible because we can't meaningfully compare lambdas with each other. As an alternative, we can add a version ofcomposed
that accepts a key to base equality on.Simplified, something like this: