Add a version of Modifier.composed that accepts a key as well to determine equality [205851704]

Fixed

Feature Request

Status Update

No update yet.

Description

je...@google.com

created issue #1

Nov 10, 2021 06:07PM

Currently, Modifier.composed { /*code*/ } != Modifier.composed { /*same code*/ }, which can lead to unexpected results in some cases.

For example, Modifier.testTag("tag") is inferred to be static, but Modifier.testTag("tag") != Modifier.testTag("tag"), which will make a difference when Live Literals is enabled.

To fix this, we need to implement ComposedModifier.equals(), which is not possible because we can't meaningfully compare lambdas with each other. As an alternative, we can add a version of composed that accepts a key to base equality on.

Simplified, something like this:

private class ComposedModifier(
    val key: String?,
    val factory: @Composable Modifier.() -> Modifier
) : Modifier.Element {
    override fun equals(other: Any?): Boolean {
        return key != null && (other as? ComposedModifier).key == key
    }
}

Comments

je...@google.com <je...@google.com> #2Nov 10, 2021 06:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

po...@google.com <po...@google.com> Nov 12, 2021 10:59AM

Assigned to ad...@google.com.

ad...@google.com <ad...@google.com> Nov 12, 2021 10:48PM

Accepted by ad...@google.com.

ap...@google.com <ap...@google.com> #3Nov 15, 2021 08:34PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

Issue 205851704

Description

Issue summary

Comments

je...@google.com <je...@google.com> #2Nov 10, 2021 06:09PM

po...@google.com <po...@google.com> Nov 12, 2021 10:59AM

ad...@google.com <ad...@google.com> Nov 12, 2021 10:48PM

ap...@google.com <ap...@google.com> #3Nov 15, 2021 08:34PM

Add comment

Issue metadata