Fixed
Status Update
Comments
po...@google.com <po...@google.com>
co...@google.com <co...@google.com>
sg...@google.com <sg...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit b925baec97c19cb542f90318091ab2d66bc448c5
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Jul 11 14:38:27 2022
Adds support for dragging Material 3 top app bars
- Updates the `heightOffset` setter at the TopAppBarState to always
coerce values between zero and `heightOffsetLimit`.
- Adds a draggable Modifier to the app bar Surfaces and update the app
bar's height when dragged.
- Adds `isPinned` flag to the TopAppBarScrollBehavior to support
blocking any dragging from pinned app bars.
- Renames the `rememberTopAppBarScrollState()` funtion to
`rememberTopAppBarState()` to match the latest API changes around that
state class.
Bug: 205873416
Test: AppBarTest
Relnote: "Allow dragging the top app bar from the bar itself."
Change-Id: I65c00deb7acc54e900d72ed157cc6d2dcea7a3fa
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/ui/common/CatalogScaffold.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoApp.kt
https://android-review.googlesource.com/2150140
Branch: androidx-main
commit b925baec97c19cb542f90318091ab2d66bc448c5
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Jul 11 14:38:27 2022
Adds support for dragging Material 3 top app bars
- Updates the `heightOffset` setter at the TopAppBarState to always
coerce values between zero and `heightOffsetLimit`.
- Adds a draggable Modifier to the app bar Surfaces and update the app
bar's height when dragged.
- Adds `isPinned` flag to the TopAppBarScrollBehavior to support
blocking any dragging from pinned app bars.
- Renames the `rememberTopAppBarScrollState()` funtion to
`rememberTopAppBarState()` to match the latest API changes around that
state class.
Bug: 205873416
Test: AppBarTest
Relnote: "Allow dragging the top app bar from the bar itself."
Change-Id: I65c00deb7acc54e900d72ed157cc6d2dcea7a3fa
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/ui/common/CatalogScaffold.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoApp.kt
Description
When scrolling with finger on top of the Appbar its not scrolling the container. Problematic when using landscape orientation if not possible to scroll away the top bar itself covering the screen height.