Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Nov 12, 2021 05:56PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from core/core/lint-baseline.xml and address the associated issues before your next stable release.

55 instance(s) of `ClassVerificationFailure`

This call references a method added in API level 19; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 92:
```
    if (!Objects.equals(foreground.getModel(), background.getModel())) {
                 ~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 92:
```
    if (!Objects.equals(foreground.getModel(), background.getModel())) {
                                   ~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 92:
```
    if (!Objects.equals(foreground.getModel(), background.getModel())) {
                                                          ~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 94:
```
                "Color models must match (" + foreground.getModel() + " vs. "
                                                         ~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 95:
```
                        + background.getModel() + ")");
                                     ~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 98:
```
    Color s = Objects.equals(background.getColorSpace(), foreground.getColorSpace())
                      ~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 98:
```
    Color s = Objects.equals(background.getColorSpace(), foreground.getColorSpace())
                                        ~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 98:
```
    Color s = Objects.equals(background.getColorSpace(), foreground.getColorSpace())
                                                                    ~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 100:
```
            : foreground.convert(background.getColorSpace());
                         ~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 100:
```
            : foreground.convert(background.getColorSpace());
                                            ~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 102:
```
    float[] src = s.getComponents();
                    ~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 103:
```
    float[] dst = background.getComponents();
                             ~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 105:
```
    float sa = s.alpha();
                 ~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 107:
```
    float da = background.alpha() * (1.0f - sa);
                          ~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 111:
```
    int ai = background.getComponentCount() - 1;
                        ~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 127:
```
    return Color.valueOf(dst, background.getColorSpace());
                 ~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.ColorUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/ColorUtils.java at line 127:
```
    return Color.valueOf(dst, background.getColorSpace());
                                         ~~~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 79:
```
        drawable.setAutoMirrored(mirrored);
                 ~~~~~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 96:
```
        return drawable.isAutoMirrored();
                        ~~~~~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 111:
```
        drawable.setHotspot(x, y);
                 ~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 124:
```
        drawable.setHotspotBounds(left, top, right, bottom);
                 ~~~~~~~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 136:
```
        drawable.setTint(tint);
                 ~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 150:
```
        drawable.setTintList(tint);
                 ~~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 164:
```
        drawable.setTintMode(tintMode);
                 ~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 178:
```
        return drawable.getAlpha();
                        ~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 189:
```
        drawable.applyTheme(theme);
                 ~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 198:
```
        return drawable.canApplyTheme();
                        ~~~~~~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 211:
```
        return drawable.getColorFilter();
                        ~~~~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 232:
```
            clearColorFilter(((InsetDrawable) drawable).getDrawable());
                                                        ~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 242:
```
                    child = state.getChild(i);
                                  ~~~~~~~~
```
This call references a method added in API level 21; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 269:
```
        drawable.inflate(res, parser, attrs, theme);
                 ~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 355:
```
        return drawable.setLayoutDirection(layoutDirection);
                        ~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.DrawableCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/DrawableCompat.java at line 392:
```
        return drawable.getLayoutDirection();
                        ~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 546:
```
            icon = Icon.createWithBitmap((Bitmap) mObj1);
                        ~~~~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 550:
```
                icon = Icon.createWithAdaptiveBitmap((Bitmap) mObj1);
                            ~~~~~~~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 552:
```
                icon = Icon.createWithBitmap(
                            ~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 557:
```
            icon = Icon.createWithResource(getResPackage(), mInt1);
                        ~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 560:
```
            icon = Icon.createWithData((byte[]) mObj1, mInt1, mInt2);
                        ~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 563:
```
            icon = Icon.createWithContentUri((String) mObj1);
                        ~~~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 580:
```
                icon = Icon.createWithAdaptiveBitmap(BitmapFactory.decodeStream(is));
                            ~~~~~~~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 582:
```
                icon = Icon.createWithBitmap(createLegacyIconFromAdaptiveIcon(
                            ~~~~~~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 590:
```
        icon.setTintList(mTintList);
             ~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 593:
```
        icon.setTintMode(mTintMode);
             ~~~~~~~~~~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 641:
```
        return toIcon(context).loadDrawable(context);
                               ~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 694:
```
                    return new AdaptiveIconDrawable(null,
                           ~~~~~~~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 28; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 1101:
```
        return icon.getType();
                    ~~~~~~~
```
This call references a method added in API level 28; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 1129:
```
        return icon.getResPackage();
                    ~~~~~~~~~~~~~
```
This call references a method added in API level 28; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 1158:
```
        return icon.getResId();
                    ~~~~~~~~
```
This call references a method added in API level 28; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 1186:
```
        return icon.getUri();
                    ~~~~~~
```
This call references a method added in API level 30; however, the containing class androidx.core.graphics.drawable.IconCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/drawable/IconCompat.java at line 567:
```
                icon = Icon.createWithAdaptiveBitmapContentUri(getUri());
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
This call references a method added in API level 29; however, the containing class androidx.core.graphics.Insets is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/Insets.java at line 198:
```
    return android.graphics.Insets.of(left, top, right, bottom);
                                   ~~
```
This call references a method added in API level 23; however, the containing class androidx.core.graphics.PaintCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/PaintCompat.java at line 52:
```
        return paint.hasGlyph(string);
                     ~~~~~~~~
```
This call references a method added in API level 29; however, the containing class androidx.core.graphics.PaintCompat is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/PaintCompat.java at line 127:
```
        paint.setBlendMode(blendMode != null ? obtainBlendModeFromCompat(blendMode) : null);
              ~~~~~~~~~~~~
```
This call references a method added in API level 26; however, the containing class androidx.core.graphics.PathUtils is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/PathUtils.java at line 60:
```
    float[] pathData = path.approximate(error);
                            ~~~~~~~~~~~
```
This call references a method added in API level 19; however, the containing class androidx.core.graphics.TypefaceCompatUtil is reachable from earlier API levels and will fail run-time class verification.

Found in src/main/java/androidx/core/graphics/TypefaceCompatUtil.java at line 110:
```
    try (ParcelFileDescriptor pfd = resolver.openFileDescriptor(uri, "r", cancellationSignal)) {
                                             ~~~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> Jan 10, 2022 05:01PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #2Jan 13, 2022 03:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 497054fb1d5924d21c025d05f8eb7167173db98b
Author: Alan Viverette <alanv@google.com>
Date: Mon Jan 10 12:02:47 2022

Lint and VFY clean-up for androidx.core.graphics

No functional changes, only auto-fixes. Cleans up some nullability.

Relnote: Cleaned up nullability for a subset of androidx.core APIs.
Fixes: 206113818
Test: Existing androidx.core.graphics tests
Change-Id: Ib2583f0cb8d6bcf8b94141069ac6834e29dc7759

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/graphics/drawable/IconCompat.java
M core/core/src/main/java/androidx/core/graphics/Insets.java
M core/core/src/main/java/androidx/core/graphics/ColorUtils.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
M core/core/api/public_plus_experimental_current.txt
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatUtil.java
M core/core/api/current.txt
M core/core/src/main/java/androidx/core/graphics/PathUtils.java
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M core/core/lint-baseline.xml

https://android-review.googlesource.com/1944325

al...@google.com <al...@google.com> #3Jan 13, 2022 03:23PM

Accepted by al...@google.com.

Reverting due to issues in CL.

ap...@google.com <ap...@google.com> #4Jan 21, 2022 10:47PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit cacb6d54f7fea4cd372ac53d2f515dc358910eef
Author: Alan Viverette <alanv@google.com>
Date: Thu Jan 13 10:47:04 2022

Lint and VFY clean-up for androidx.core.graphics

No functional changes, only auto-fixes. Cleans up some nullability.

This reverts commit 7ad7d9096a7ae249ef930acc80bd5cb6640ddf8d.

Reason for revert: Fixed VFY failure in IconCompat on API level < 23

Relnote: Cleaned up nullability for a subset of androidx.core APIs.
Fixes: 206113818
Test: ShortcutInfoCompatTest
Merged-In: Ia0e2fef924851e9f96dc316bdaff55c61e60400f
Change-Id: Ia0e2fef924851e9f96dc316bdaff55c61e60400f

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/graphics/drawable/IconCompat.java
M core/core/src/main/java/androidx/core/graphics/Insets.java
M core/core/src/main/java/androidx/core/graphics/ColorUtils.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
M core/core/api/public_plus_experimental_current.txt
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatUtil.java
M core/core/api/current.txt
M core/core/src/main/java/androidx/core/graphics/PathUtils.java
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M core/core/lint-baseline.xml

https://android-review.googlesource.com/1948719

IssueTracker

Fix 55 lint baseline suppression(s) of ClassVerificationFailure

Status Update

Description

55 instance(s) of `ClassVerificationFailure`

Comments

al...@google.com <al...@google.com> Jan 10, 2022 05:01PM

ap...@google.com <ap...@google.com> #2Jan 13, 2022 03:21PM

al...@google.com <al...@google.com> #3Jan 13, 2022 03:23PM

ap...@google.com <ap...@google.com> #4Jan 21, 2022 10:47PM

Issue 206113818

Description

55 instance(s) of ClassVerificationFailure

Issue summary

Comments

al...@google.com <al...@google.com> Jan 10, 2022 05:01PM

ap...@google.com <ap...@google.com> #2Jan 13, 2022 03:21PM

al...@google.com <al...@google.com> #3Jan 13, 2022 03:23PM

ap...@google.com <ap...@google.com> #4Jan 21, 2022 10:47PM

Add comment

Issue metadata

55 instance(s) of `ClassVerificationFailure`