Fixed
Status Update
Comments
jb...@google.com <jb...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
ja...@deepl.com <ja...@deepl.com> #3
since it is already marked as deprecated, we can probably do it by now.
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
Opening diff shortly
jb...@google.com <jb...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ja...@deepl.com <ja...@deepl.com> #6
Wonderful news - thank you for the fast replies!
Description
Component used: Navigation
Version used: 2.4.0-beta02
Devices/Android versions reproduced on: Every device
I'm using Compose with the navigation components. I inject a ViewModel via Hilt.
I navigate with the
NavGraphBuilder.composable()
extension, which works.When I open my composable within a Dialog via the
NavGraphBuilder.dialog()
extension I run into the following problem:Closing the dialog with the system back button works. When I call
navController.popBackstack()
this exception occurs and the app crashes:I observed that my crashing composable is recomposed after
navController.popBackstack()
, which ultimately leads to the crash. Is there a reason for the additional recompositions?