NavGraphBuilder.dialog [206465487]

Fixed

Bug

Status Update

No update yet.

Description

ja...@deepl.com

created issue #1

Nov 16, 2021 02:51PM

Component used: Navigation

Version used: 2.4.0-beta02

Devices/Android versions reproduced on: Every device

I'm using Compose with the navigation components. I inject a ViewModel via Hilt.

I navigate with the NavGraphBuilder.composable() extension, which works.

When I open my composable within a Dialog via the NavGraphBuilder.dialog() extension I run into the following problem:

Closing the dialog with the system back button works. When I call navController.popBackstack() this exception occurs and the app crashes:

java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels until it is added to the NavController's back stack (i.e., the Lifecycle of the NavBackStackEntry reaches the CREATED state).
        at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:180)
        at androidx.lifecycle.ViewModelProvider.<init>(ViewModelProvider.java:114)
        at androidx.lifecycle.viewmodel.compose.ViewModelKt.get(ViewModel.kt:80)
        at androidx.lifecycle.viewmodel.compose.ViewModelKt.viewModel(ViewModel.kt:72)

I observed that my crashing composable is recomposed after navController.popBackstack(), which ultimately leads to the crash. Is there a reason for the additional recompositions?

Comments

jb...@google.com <jb...@google.com> #2Nov 16, 2021 03:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ja...@deepl.com <ja...@deepl.com> #3Nov 18, 2021 10:13AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

il...@google.com <il...@google.com> Nov 18, 2021 04:26PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Nov 18, 2021 10:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

jb...@google.com <jb...@google.com> #5Nov 18, 2021 10:55PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.4.0-rc01 release.

The fix is actually a work around for a larger issue for Dialogs in Compose which will be tracked here.

ja...@deepl.com <ja...@deepl.com> #6Nov 19, 2021 08:08AM

Wonderful news - thank you for the fast replies!

Issue 206465487