Flaky build failure in MergeResources task [206674992]

Fixed

Bug

Status Update

No update yet.

Description

ku...@gmail.com

created issue #1

Nov 16, 2021 11:23PM

On CI builds we are seeing the following build failure happen occasionally during an incremental build. For example we do a build, then apply a change from a git commit, and build again.

We have enabled the following two properties for making the mergeResources task relocatable which could be the reason from looking at the stacktrace:

android.experimental.enableSourceSetPathsMap=true
android.experimental.cacheCompileLibResources=true

The app module also uses custom res source set locations in case that is relevant:

android.sourceSets { main.res.srcDirs = [ 'src/main/res/foo', 'src/main/res/bar' ] }

Stacktrace:

Task :app:mergeReleaseResources
java.lang.IllegalArgumentException: Unable to locate resourceFile (/.../app/build/intermediates/merged-not-compiled-resources/release/interpolator/mtrl_fast_out_slow_in.xml) in source-sets.
	at com.android.ide.common.resources.RelativeResourceUtils.getRelativeSourceSetPath(RelativeResourceUtils.kt:46)
	at com.android.ide.common.resources.MergedResourceWriter.getSourceFilePath(MergedResourceWriter.java:333)
	at com.android.ide.common.resources.MergedResourceWriter.removeOutFile(MergedResourceWriter.java:755)
	at com.android.ide.common.resources.MergedResourceWriter.removeFileFromNotCompiledOutputDir(MergedResourceWriter.java:723)
	at com.android.ide.common.resources.MergedResourceWriter.removeOutFile(MergedResourceWriter.java:741)
	at com.android.ide.common.resources.MergedResourceWriter.removeItem(MergedResourceWriter.java:448)
	at com.android.ide.common.resources.MergedResourceWriter.removeItem(MergedResourceWriter.java:71)
	at com.android.ide.common.resources.DataMerger.mergeData(DataMerger.java:276)
	at com.android.ide.common.resources.ResourceMerger.mergeData(ResourceMerger.java:385)
	at com.android.build.gradle.tasks.MergeResources.doTaskAction(MergeResources.java:497)
	at com.android.build.gradle.internal.tasks.NewIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(BaseTask.kt:66)
	at com.android.build.gradle.internal.tasks.Blocks.recordSpan(Blocks.java:51)
	at com.android.build.gradle.internal.tasks.NewIncrementalTask.taskAction(NewIncrementalTask.kt:45)

Version of Gradle Plugin: 7.0.0

Version of Gradle: Gradle 7.2

Version of Java: 11

OS: centOS

Comments

gh...@google.com <gh...@google.com> Nov 17, 2021 09:05PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Nov 22, 2021 05:54PM

Reassigned to cm...@google.com.

ku...@gmail.com <ku...@gmail.com> #2Feb 26, 2022 12:38AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

ga...@google.com <ga...@google.com> #3Aug 23, 2022 11:32AM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

Message last modified on Aug 23, 2022 11:34AM

inc_res.zip

847 KB

Download

lu...@google.com <lu...@google.com> Aug 23, 2022 11:35AM

Accepted by lu...@google.com.

lu...@google.com <lu...@google.com> #4Aug 23, 2022 01:58PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

lu...@google.com <lu...@google.com> #5Aug 23, 2022 02:37PM

I will backport this to the 8.0 and 4.0 branches.

lu...@google.com <lu...@google.com> Aug 23, 2022 04:39PM

Marked as fixed.

pa...@gmail.com <pa...@gmail.com> #6Mar 7, 2023 03:40PM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

kh...@gmail.com <kh...@gmail.com> #7Apr 4, 2023 06:57AM

Comment has been deleted.

Message last modified on Apr 4, 2023 01:42PM

sa...@peilicke.de <sa...@peilicke.de> #8May 25, 2023 07:51AM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

lu...@google.com <lu...@google.com> #9May 25, 2023 01:32PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

Issue 206674992

Description

Issue summary

Comments

gh...@google.com <gh...@google.com> Nov 17, 2021 09:05PM

je...@google.com <je...@google.com> Nov 22, 2021 05:54PM

ku...@gmail.com <ku...@gmail.com> #2Feb 26, 2022 12:38AM

ga...@google.com <ga...@google.com> #3Aug 23, 2022 11:32AM

lu...@google.com <lu...@google.com> Aug 23, 2022 11:35AM

lu...@google.com <lu...@google.com> #4Aug 23, 2022 01:58PM

lu...@google.com <lu...@google.com> #5Aug 23, 2022 02:37PM

lu...@google.com <lu...@google.com> Aug 23, 2022 04:39PM

pa...@gmail.com <pa...@gmail.com> #6Mar 7, 2023 03:40PM

kh...@gmail.com <kh...@gmail.com> #7Apr 4, 2023 06:57AM

sa...@peilicke.de <sa...@peilicke.de> #8May 25, 2023 07:51AM

lu...@google.com <lu...@google.com> #9May 25, 2023 01:32PM

Add comment

Issue metadata