NullPointerException at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245) [206677462]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Nov 17, 2021 01:09PM

Hello, noticed a NPE crash in compose ui after updating from 1.1.0-alpha05 to 1.1.0-beta01. Crash happening in RenderNodeLayer.updateDisplayList and happening 100% on Android 10 Huawei devices as reported on crashlytics. Initially thought it was due to code obfuscation issue but managed to replicate it consistently on a non obfuscated build.

java.lang.NullPointerException
                         E      at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245)
                         E      at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:760)
                         E      at android.view.View.draw(View.java:21654)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20511)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.View.draw(View.java:21378)
                         E      at android.view.ViewGroup.drawChild(ViewGroup.java:4604)
                         E      at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4363)
                         E      at android.view.View.draw(View.java:21654)
                         E      at com.android.internal.policy.DecorView.draw(DecorView.java:1005)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20511)
                         E      at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:584)
                         E      at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:590)
                         E      at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:668)
                         E      at android.view.ViewRootImpl.draw(ViewRootImpl.java:3892)
                         E      at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:3700)
                         E      at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2989)
                         E      at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1876)
                         E      at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8167)
                         E      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1057)
                         E      at android.view.Choreographer.doCallbacks(Choreographer.java:875)
                         E      at android.view.Choreographer.doFrame(Choreographer.java:776)
                         E      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1042)
                         E      at android.os.Handler.handleCallback(Handler.java:900)
                         E      at android.os.Handler.dispatchMessage(Handler.java:103)
                         E      at android.os.Looper.loop(Looper.java:219)
                         E      at android.app.ActivityThread.main(ActivityThread.java:8349)
                         E      at java.lang.reflect.Method.invoke(Native Method)
                         E      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
                         E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1055)

Noticed from the stacktrace that somehow drawBlock in updateDisplayList is null but not sure in what scenarios it could become null?

Comments

ae...@google.com <ae...@google.com> #2Nov 17, 2021 07:31PM

Assigned to nj...@google.com.

At the jetpack compose codelab

https://codelabs.developers.google.com/codelabs/jetpack-compose-state/index.html?index=..%2F..index#3

when we create new items on the TODO's list, if we create more items and scroll, it will not be a smooth scroll

tp...@gmail.com <tp...@gmail.com> #3Nov 18, 2021 03:30AM

Yes, it is definitely recommended to use loadImageResource as loading large images on the ui thread will always make the scrolling laggy. Just to confirm, could you please try the same but without image at all? Without calling imageResource and Image. maybe just replace it with
Box(modifier = imageModifier.background(Color.Gray))
I am curious if the scrolling will still be laggy in such case

Snip20211117_38.png

38 KB

View

Download

tp...@gmail.com <tp...@gmail.com> #4Nov 22, 2021 08:44AM

I have tried with loadImageResource and with the Box you suggested and its still laggy hmm

I have also tried the codelab for the state tutorial (the add tasks codelab) and it only shows an icon and a Text as a row and is also choppy if we scroll

thanks for the feedback

Message last modified on Nov 22, 2021 08:56AM

tp...@gmail.com <tp...@gmail.com> #5Dec 8, 2021 03:05AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 17cd20811cfd5df0dceb95706d76248f2f7f2e42
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Tue Sep 22 20:09:35 2020

Scroll performance optimization for LazyColumnFor/LazyRowFor

We were unnecessary recomposing all the visible items on every scroll offset if the items type was not stable(if it was stable the recomposition was skipped using the regular runtime logic). In this change I introduced the itemContent lambda caching logic which allows to reuse the same lambda instance for not changed items. If we pass the same lambda instance into subcomposition the runtime will skip the whole composition as there is nothing to recompose. We clear this cache if the new itemContentFactory was provided or if the parent constraints have been changed.

Bug: 168293643
Bug: 167972292
Bug: 165028371
Relnote: Performance optimizations for LazyColumnFor/LazyRowFor scrolling by not doing unnecessary recompositions during every scroll
Test: tested manually and with a new test for both LazyColumnFor and LazyRowFor. Instead of 18 recompositions for each item for a simple scroll we do none of them.
Change-Id: I64f6568fd1193a6d28e3e2e2205b977f4a5f116b

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnForTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyRowForTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/CachingItemContentFactory.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyFor.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyForState.kt

https://android-review.googlesource.com/1434551

Wed Dec 08 2021 11:00:58 GMT+0800 (Singapore Standard Time).png

113 KB

View

Download

ma...@gmail.com <ma...@gmail.com> #6Dec 21, 2021 09:13AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc602125a9e5fc15a37ba4fa7610998a94ead29f
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Fri Sep 25 21:14:09 2020

Do less work in SubcomposeLayout when subcompose called with the same lambda

If the lambda object for the slot didn't change and there were no pending recompositons we can skip the whole subcompositions invocation as it will result in unchanged tree. Starting subcomposition is a heavy weight operation so this change allows to improve the measure benchmarks for LazyColumn scrolling by 88 percents.
To achieve it I added a hasPendingChanges() method for Composition class.

Bug: 168293643
Bug: 167972292
Bug: 165028371
Relnote: The scrolling performance of LazyColumn/Row is improved by doing less work in subcomposition on every scroll. The new hasInvalidations() method was added for Composition class. hasPendingChanges() method from Recomposer was renamed to hasInvalidations()
Test: This is not changing the behavior so I can't cover it with a unit test, but it dramatically improves the benchmark. So if this optimization will stop working in the future we will get a regression.
Change-Id: Ib2f324dd6845fd83321e0d4f3fa6e502c346dbc3

M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/AmbientTests.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ComposeView.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/SubcomposeLayout.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/android/ComposeIdlingResource.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/android/CompositionAwaiter.kt
M ui/ui-test/src/desktopMain/kotlin/androidx/ui/test/DesktopComposeTestRule.kt

https://android-review.googlesource.com/1439054

th...@gmail.com <th...@gmail.com> #7Jan 6, 2022 05:38PM

There is one optimization for LazyColumn scrolling has been merged in alpha04 and another is upcoming in alpha05.

I will close the bug as fixed for now, Please feel free to comment again if after migrating to alpha05 and starting using loadImageResource for an item the scrolling performance is still unacceptable. Thanks!

Message last modified on Jan 6, 2022 05:39PM

st...@google.com <st...@google.com> #8Jan 7, 2022 02:04PM

Thanks for your efforts improving the performance of the lazy lists! I was able to observe some improvements.

However it's still slow from my testing on alpha05. I tried removing the image loading (which I was loading with Glide) and just replaced them with Box(Modifier.background(DsToken.colors.backgroundSecondary) and the )(slow) performance is around the same for the initial scroll.

It seems, when all items have been rendered, it starts to scroll smoothly. So I supposed there's something slow with the initial composition for each of the lazy item. Before, the scrolling was just slow throughout the whole app session.

th...@gmail.com <th...@gmail.com> #9Jan 10, 2022 01:23PM

yes, the composition itself is still quite slow. so we do pretty much a lot of work every time we need to compose a new item.
maybe if you can create a working repro sample app which I can check out and debug more?

st...@google.com <st...@google.com> #10Jan 10, 2022 03:16PM

Thomas, is your code also using AnimatedVectorDrawables like the example in the original report?

We are using AVDs in a dialog sample, but I haven't seen that error - perhaps you could test it on your devices to see if it can trigger the exception? https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/samples/src/main/java/androidx/wear/compose/material/samples/DialogSample.kt;l=118

th...@gmail.com <th...@gmail.com> #11Jan 10, 2022 03:43PM

AnimatedVectorDrawables work fine on the Galaxy Watch4. I am actually using the sample for the open on phone animation you linked in my project already, which works without any issues.

nj...@google.com <nj...@google.com> #12Jan 12, 2022 11:51PM

I have tried the sample github project in comment #4 however, it either shows an error indicating the pin codes do not match (even though they do) or the spinning animation continues indefinitely without crashing.

I recommend updating to the latest version of compose or providing a more minimal sample application for the team to look into.

Message last modified on Jan 12, 2022 11:52PM

tp...@gmail.com <tp...@gmail.com> #13Jan 13, 2022 06:14AM

Are you running the sample on specific device? The github project is crashing only on Huawei devices running Android 10 or certain android 7 devices. I have tried it again on emulator running on Android 7 API 24 also able to reproduce the crash. Video as attached.

2022-01-13 14:09:57.183 3991-3991/com.terence.composeTest E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.terence.composeTest, PID: 3991
    java.lang.NullPointerException
        at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:760)
        at android.view.View.draw(View.java:17074)
        at android.view.View.updateDisplayListIfDirty(View.java:16053)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:656)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:662)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:770)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:2796)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2604)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2211)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1246)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6301)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:871)
        at android.view.Choreographer.doCallbacks(Choreographer.java:683)
        at android.view.Choreographer.doFrame(Choreographer.java:619)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:857)
        at android.os.Handler.handleCallback(Handler.java:751)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6077)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
2022

device-2022-01-13-141002.webm

5.4 MB

Download

ap...@google.com <ap...@google.com> #14Jan 14, 2022 12:57AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f4ad578674a55af824e19d6e921dcd68f5eeff82
Author: Nader Jawad <njawad@google.com>
Date: Wed Jan 12 16:10:47 2022

Add defensive null check

Add conditional let block within
logic to record drawing operations
in case the displaylist for a RenderNodeLayer
is attempted to be updated after the layer
has been destroyed

Fixes: 206677462
Test: re-ran compose tests
Change-Id: I838d3170547716fa35d6e9b630db995075e814d9

M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt

https://android-review.googlesource.com/1947059

to...@branchapp.com <to...@branchapp.com> #15Jan 19, 2022 10:32PM

Is there a temporary workaround while we wait for the fix to get released? We're experiencing this crash quite a bit but the logs give no indication as to where in our code it is happening

ri...@ffw.com <ri...@ffw.com> #16Jan 20, 2022 12:06PM

Any chance for 1.1.0-rc02? Or could you give me a link to the snapshot including this fix?

th...@gmail.com <th...@gmail.com> #17Jan 21, 2022 11:27PM

Thanks for the fix! I can confirm it works with the latest snapshot in my Wear OS app.

Message last modified on Jan 21, 2022 11:30PM

lc...@gmail.com <lc...@gmail.com> #18Jan 30, 2022 07:56AM

Can this fix be ported to 1.1.0 version too? i see that its currently onl in 1.2.0-alpha02

fr...@instacart.com <fr...@instacart.com> #19Feb 7, 2022 11:08PM

+1, this is forcing us to downgrade compose and kotlin, this needs to be in 1.1

be...@google.com <be...@google.com> #20Feb 14, 2022 08:58PM

This fix has been cherry picked to 1.1.1 as well

na...@google.com <na...@google.com> #21Oct 24, 2022 01:38PM

The following release(s) address this bug:

androidx.compose.ui:ui:1.3.0

Issue 206677462

Description

Issue summary

Comments

ae...@google.com <ae...@google.com> #2Nov 17, 2021 07:31PM

tp...@gmail.com <tp...@gmail.com> #3Nov 18, 2021 03:30AM

tp...@gmail.com <tp...@gmail.com> #4Nov 22, 2021 08:44AM

tp...@gmail.com <tp...@gmail.com> #5Dec 8, 2021 03:05AM

ma...@gmail.com <ma...@gmail.com> #6Dec 21, 2021 09:13AM

th...@gmail.com <th...@gmail.com> #7Jan 6, 2022 05:38PM

st...@google.com <st...@google.com> #8Jan 7, 2022 02:04PM

th...@gmail.com <th...@gmail.com> #9Jan 10, 2022 01:23PM

st...@google.com <st...@google.com> #10Jan 10, 2022 03:16PM

th...@gmail.com <th...@gmail.com> #11Jan 10, 2022 03:43PM

nj...@google.com <nj...@google.com> #12Jan 12, 2022 11:51PM

tp...@gmail.com <tp...@gmail.com> #13Jan 13, 2022 06:14AM

ap...@google.com <ap...@google.com> #14Jan 14, 2022 12:57AM

to...@branchapp.com <to...@branchapp.com> #15Jan 19, 2022 10:32PM

ri...@ffw.com <ri...@ffw.com> #16Jan 20, 2022 12:06PM

th...@gmail.com <th...@gmail.com> #17Jan 21, 2022 11:27PM

lc...@gmail.com <lc...@gmail.com> #18Jan 30, 2022 07:56AM

fr...@instacart.com <fr...@instacart.com> #19Feb 7, 2022 11:08PM

be...@google.com <be...@google.com> #20Feb 14, 2022 08:58PM

na...@google.com <na...@google.com> #21Oct 24, 2022 01:38PM

Add comment

Issue metadata