NullPointerException at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245) [206677462]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Nov 17, 2021 01:09PM

Hello, noticed a NPE crash in compose ui after updating from 1.1.0-alpha05 to 1.1.0-beta01. Crash happening in RenderNodeLayer.updateDisplayList and happening 100% on Android 10 Huawei devices as reported on crashlytics. Initially thought it was due to code obfuscation issue but managed to replicate it consistently on a non obfuscated build.

java.lang.NullPointerException
                         E      at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245)
                         E      at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:760)
                         E      at android.view.View.draw(View.java:21654)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20511)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4586)
                         E      at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4559)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20469)
                         E      at android.view.View.draw(View.java:21378)
                         E      at android.view.ViewGroup.drawChild(ViewGroup.java:4604)
                         E      at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4363)
                         E      at android.view.View.draw(View.java:21654)
                         E      at com.android.internal.policy.DecorView.draw(DecorView.java:1005)
                         E      at android.view.View.updateDisplayListIfDirty(View.java:20511)
                         E      at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:584)
                         E      at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:590)
                         E      at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:668)
                         E      at android.view.ViewRootImpl.draw(ViewRootImpl.java:3892)
                         E      at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:3700)
                         E      at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2989)
                         E      at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1876)
                         E      at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8167)
                         E      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1057)
                         E      at android.view.Choreographer.doCallbacks(Choreographer.java:875)
                         E      at android.view.Choreographer.doFrame(Choreographer.java:776)
                         E      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1042)
                         E      at android.os.Handler.handleCallback(Handler.java:900)
                         E      at android.os.Handler.dispatchMessage(Handler.java:103)
                         E      at android.os.Looper.loop(Looper.java:219)
                         E      at android.app.ActivityThread.main(ActivityThread.java:8349)
                         E      at java.lang.reflect.Method.invoke(Native Method)
                         E      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
                         E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1055)

Noticed from the stacktrace that somehow drawBlock in updateDisplayList is null but not sure in what scenarios it could become null?

Comments

ae...@google.com <ae...@google.com> #2Nov 17, 2021 07:31PM

Assigned to nj...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

tp...@gmail.com <tp...@gmail.com> #3Nov 18, 2021 03:30AM

Thanks for the report!

Snip20211117_38.png

38 KB

View

Download

tp...@gmail.com <tp...@gmail.com> #4Nov 22, 2021 08:44AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Message last modified on Nov 22, 2021 08:56AM

tp...@gmail.com <tp...@gmail.com> #5Dec 8, 2021 03:05AM

deleted

Wed Dec 08 2021 11:00:58 GMT+0800 (Singapore Standard Time).png

113 KB

View

Download

ma...@gmail.com <ma...@gmail.com> #6Dec 21, 2021 09:13AM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

th...@gmail.com <th...@gmail.com> #7Jan 6, 2022 05:38PM

I am running into the same issue with my Compose app on Wear OS. Samsung Galaxy Watch4. Could this please be fixed?

    java.lang.NullPointerException
        at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:292)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:857)
        at android.view.View.draw(View.java:22879)
        at android.view.View.updateDisplayListIfDirty(View.java:21744)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4537)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4509)
        at android.view.View.updateDisplayListIfDirty(View.java:21698)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4537)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4509)
        at android.view.View.updateDisplayListIfDirty(View.java:21698)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4537)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4509)
        at android.view.View.updateDisplayListIfDirty(View.java:21698)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:559)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:565)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:642)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:4270)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:3983)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3231)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2048)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8575)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:998)
        at android.view.Choreographer.doCallbacks(Choreographer.java:796)
        at android.view.Choreographer.doFrame(Choreographer.java:731)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:983)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:246)
        at android.app.ActivityThread.main(ActivityThread.java:7690)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995)

Message last modified on Jan 6, 2022 05:39PM

st...@google.com <st...@google.com> #8Jan 7, 2022 02:04PM

Re https://b.corp.google.com/issues/206677462#comment7, would you be able to share a cutdown sample of the Wear Compose app?

th...@gmail.com <th...@gmail.com> #9Jan 10, 2022 01:23PM

I have not been able to create a sample for the crash with Wear Compose. What I did find out is that if I remove PositionIndicator from my code the crash no longer occurs. See also: https://kotlinlang.slack.com/archives/C02GBABJUAF/p1641491021002200

st...@google.com <st...@google.com> #10Jan 10, 2022 03:16PM

Thomas, is your code also using AnimatedVectorDrawables like the example in the original report?

We are using AVDs in a dialog sample, but I haven't seen that error - perhaps you could test it on your devices to see if it can trigger the exception? https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/samples/src/main/java/androidx/wear/compose/material/samples/DialogSample.kt;l=118

th...@gmail.com <th...@gmail.com> #11Jan 10, 2022 03:43PM

AnimatedVectorDrawables work fine on the Galaxy Watch4. I am actually using the sample for the open on phone animation you linked in my project already, which works without any issues.

nj...@google.com <nj...@google.com> #12Jan 12, 2022 11:51PM

I have tried the sample github project in comment #4 however, it either shows an error indicating the pin codes do not match (even though they do) or the spinning animation continues indefinitely without crashing.

I recommend updating to the latest version of compose or providing a more minimal sample application for the team to look into.

Message last modified on Jan 12, 2022 11:52PM

tp...@gmail.com <tp...@gmail.com> #13Jan 13, 2022 06:14AM

Are you running the sample on specific device? The github project is crashing only on Huawei devices running Android 10 or certain android 7 devices. I have tried it again on emulator running on Android 7 API 24 also able to reproduce the crash. Video as attached.

2022-01-13 14:09:57.183 3991-3991/com.terence.composeTest E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.terence.composeTest, PID: 3991
    java.lang.NullPointerException
        at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList(RenderNodeLayer.android.kt:245)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:760)
        at android.view.View.draw(View.java:17074)
        at android.view.View.updateDisplayListIfDirty(View.java:16053)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:3748)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:3728)
        at android.view.View.updateDisplayListIfDirty(View.java:16016)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:656)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:662)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:770)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:2796)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2604)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2211)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1246)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6301)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:871)
        at android.view.Choreographer.doCallbacks(Choreographer.java:683)
        at android.view.Choreographer.doFrame(Choreographer.java:619)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:857)
        at android.os.Handler.handleCallback(Handler.java:751)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6077)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
2022

device-2022-01-13-141002.webm

5.4 MB

Download

ap...@google.com <ap...@google.com> #14Jan 14, 2022 12:57AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f4ad578674a55af824e19d6e921dcd68f5eeff82
Author: Nader Jawad <njawad@google.com>
Date: Wed Jan 12 16:10:47 2022

Add defensive null check

Add conditional let block within
logic to record drawing operations
in case the displaylist for a RenderNodeLayer
is attempted to be updated after the layer
has been destroyed

Fixes: 206677462
Test: re-ran compose tests
Change-Id: I838d3170547716fa35d6e9b630db995075e814d9

M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt

https://android-review.googlesource.com/1947059

to...@branchapp.com <to...@branchapp.com> #15Jan 19, 2022 10:32PM

Is there a temporary workaround while we wait for the fix to get released? We're experiencing this crash quite a bit but the logs give no indication as to where in our code it is happening

ri...@ffw.com <ri...@ffw.com> #16Jan 20, 2022 12:06PM

Any chance for 1.1.0-rc02? Or could you give me a link to the snapshot including this fix?

th...@gmail.com <th...@gmail.com> #17Jan 21, 2022 11:27PM

Thanks for the fix! I can confirm it works with the latest snapshot in my Wear OS app.

Message last modified on Jan 21, 2022 11:30PM

lc...@gmail.com <lc...@gmail.com> #18Jan 30, 2022 07:56AM

Can this fix be ported to 1.1.0 version too? i see that its currently onl in 1.2.0-alpha02

fr...@instacart.com <fr...@instacart.com> #19Feb 7, 2022 11:08PM

+1, this is forcing us to downgrade compose and kotlin, this needs to be in 1.1

be...@google.com <be...@google.com> #20Feb 14, 2022 08:58PM

This fix has been cherry picked to 1.1.1 as well

na...@google.com <na...@google.com> #21Oct 24, 2022 01:38PM

The following release(s) address this bug:

androidx.compose.ui:ui:1.3.0

Issue 206677462

Description

Issue summary

Comments

ae...@google.com <ae...@google.com> #2Nov 17, 2021 07:31PM

tp...@gmail.com <tp...@gmail.com> #3Nov 18, 2021 03:30AM

tp...@gmail.com <tp...@gmail.com> #4Nov 22, 2021 08:44AM

tp...@gmail.com <tp...@gmail.com> #5Dec 8, 2021 03:05AM

ma...@gmail.com <ma...@gmail.com> #6Dec 21, 2021 09:13AM

th...@gmail.com <th...@gmail.com> #7Jan 6, 2022 05:38PM

st...@google.com <st...@google.com> #8Jan 7, 2022 02:04PM

th...@gmail.com <th...@gmail.com> #9Jan 10, 2022 01:23PM

st...@google.com <st...@google.com> #10Jan 10, 2022 03:16PM

th...@gmail.com <th...@gmail.com> #11Jan 10, 2022 03:43PM

nj...@google.com <nj...@google.com> #12Jan 12, 2022 11:51PM

tp...@gmail.com <tp...@gmail.com> #13Jan 13, 2022 06:14AM

ap...@google.com <ap...@google.com> #14Jan 14, 2022 12:57AM

to...@branchapp.com <to...@branchapp.com> #15Jan 19, 2022 10:32PM

ri...@ffw.com <ri...@ffw.com> #16Jan 20, 2022 12:06PM

th...@gmail.com <th...@gmail.com> #17Jan 21, 2022 11:27PM

lc...@gmail.com <lc...@gmail.com> #18Jan 30, 2022 07:56AM

fr...@instacart.com <fr...@instacart.com> #19Feb 7, 2022 11:08PM

be...@google.com <be...@google.com> #20Feb 14, 2022 08:58PM

na...@google.com <na...@google.com> #21Oct 24, 2022 01:38PM

Add comment

Issue metadata