Fixed
Status Update
No update yet.
Comments
kl...@google.com
ni...@google.com
Is this a subset of
kl...@google.com
That and
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9c32bdf8e484e94920e6ee1c06c9fd4e2189f402
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Nov 11 16:38:13 2021
Polish selection magnification behavior.
Text field selection magnification was implemented in aosp/1844741.
Selection container selection magnification was implemented in aosp/1890195.
This doc has a description of the behaviors that this CL implements:
https://docs.google.com/document/d/1NRWiCH2NL-XPPP0wYe8Ql6mnUJ9pwBcisgCxl2WhPXg/edit?usp=sharing&resourcekey=0-Hwm4817Nn_FF9Hdxk3rO7A
Fixes:
Test: Replaced too-detailed unit tests for pieces of selection
implementations with UI tests for actual behavior:
./gradlew :compose:foundation:foundation:cAT
Relnote: "Text selection magnifier behavior has been polished to
match the platform magnifier."
Change-Id: Idd918c3b321e8d7626e47a027e0b19640085a2fa
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/AbstractSelectionMagnifierTests.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionDelegate.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldMagnifierTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifier.kt
https://android-review.googlesource.com/1897100
Branch: androidx-main
commit 9c32bdf8e484e94920e6ee1c06c9fd4e2189f402
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Nov 11 16:38:13 2021
Polish selection magnification behavior.
Text field selection magnification was implemented in aosp/1844741.
Selection container selection magnification was implemented in aosp/1890195.
This doc has a description of the behaviors that this CL implements:
Fixes:
Test: Replaced too-detailed unit tests for pieces of selection
implementations with UI tests for actual behavior:
./gradlew :compose:foundation:foundation:cAT
Relnote: "Text selection magnifier behavior has been polished to
match the platform magnifier."
Change-Id: Idd918c3b321e8d7626e47a027e0b19640085a2fa
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/AbstractSelectionMagnifierTests.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionDelegate.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldMagnifierTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifier.kt
Description
TextFieldandSelectionContainerboth don't exactly match how the platform selection magnifier works in some edge cases re: animation and visibility. They should match as closely as possible. SeeRelated to: