Polish TextField and SelectionContainer magnifiers to match platform animations and visibility [206833278]

Fixed

Bug

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Nov 17, 2021 08:24PM

TextField and SelectionContainer both don't exactly match how the platform selection magnifier works in some edge cases re: animation and visibility. They should match as closely as possible. See this doc for a description of those behaviors.

Related to:

Comments

kl...@google.com <kl...@google.com> Nov 18, 2021 08:08PM

Accepted by kl...@google.com.

ni...@google.com <ni...@google.com> #2Dec 2, 2021 11:59PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

kl...@google.com <kl...@google.com> #3Dec 3, 2021 12:17AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Jan 20, 2022 02:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9c32bdf8e484e94920e6ee1c06c9fd4e2189f402
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Nov 11 16:38:13 2021

Polish selection magnification behavior.

Text field selection magnification was implemented in aosp/1844741.
Selection container selection magnification was implemented in aosp/1890195.
This doc has a description of the behaviors that this CL implements:

https://docs.google.com/document/d/1NRWiCH2NL-XPPP0wYe8Ql6mnUJ9pwBcisgCxl2WhPXg/edit?usp=sharing&resourcekey=0-Hwm4817Nn_FF9Hdxk3rO7A

Fixes:

b/206833278

Test: Replaced too-detailed unit tests for pieces of selection
implementations with UI tests for actual behavior:
./gradlew :compose:foundation:foundation:cAT
Relnote: "Text selection magnifier behavior has been polished to
match the platform magnifier."
Change-Id: Idd918c3b321e8d7626e47a027e0b19640085a2fa

A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/AbstractSelectionMagnifierTests.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionDelegate.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldMagnifierTest.kt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifier.kt

https://android-review.googlesource.com/1897100

Issue 206833278

Description

Issue summary

Comments

kl...@google.com <kl...@google.com> Nov 18, 2021 08:08PM

ni...@google.com <ni...@google.com> #2Dec 2, 2021 11:59PM

kl...@google.com <kl...@google.com> #3Dec 3, 2021 12:17AM

ap...@google.com <ap...@google.com> #4Jan 20, 2022 02:50PM

Add comment

Issue metadata