Convert `room-runtime` [206859668]

Fixed

Feature Request

Status Update

No update yet.

Description

el...@google.com

created issue #1

Nov 17, 2021 11:20PM

Converting files in `room-runtime` from Java to Kotlin.

Comments

ap...@google.com <ap...@google.com> #2Feb 4, 2022 12:03PM

For Kotlin 2.0 and KSP 2.0 the Cannot change attributes of configuration ':composeApp:debugFrameworkIosX64' after it has been locked for mutation really seems like a KSP issue. You should file a bug in their repository with a sample app if possible.

If you downgrade to Kotlin 1.9 then things 'should' work, there are example apps out there with such configuration, like the following one: https://github.com/realityexpander/KMP_Room/tree/main

ap...@google.com <ap...@google.com> #3Feb 15, 2022 12:47AM

Yes this does seem like a KSP issue however it only starts happening when room is added to the project. As the template project compiles just fine.

Will try to use the example provided by you to check if it fixes the issue.

ap...@google.com <ap...@google.com> #4Mar 7, 2022 08:33PM

Note that this issue happens when applying the Compose, KSP and Room Plugin together in Kotlin 2.0.x, the workaround for now is to not use the Room Gradle Plugin and instead specify the schema location vis KSP arguments:

// In the build.gradle
ksp {
    arg("room.schemaLocation", "${projectDir}/schemas")
}

ap...@google.com <ap...@google.com> #5Apr 27, 2022 05:16PM

Hi, I encountered a similar problem and was able to resolve it by updating the dependencies

room = "2.7.0-alpha08"
ksp = "2.0.20-1.0.25"

compose-plugin = "1.6.11"
kotlin = "2.0.20"

ap...@google.com <ap...@google.com> #6Apr 28, 2022 08:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3267211f72168a905ff880a4e34558185dc6c313
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Apr 27 14:28:44 2022

Converting `auto closer` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting `auto closer` related files in `room-runtime` from Java to Kotlin.
Change-Id: I6ee76590c1d110a4bb46219c126ef79177e3c975

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt

https://android-review.googlesource.com/2043166

ap...@google.com <ap...@google.com> #7May 17, 2022 05:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit a6f3b46c1dd9f4f1b419462c50451a120a863232
Author: Elif Bilgin <elifbilgin@google.com>
Date: Thu Apr 14 16:25:45 2022

Converting the final set of Java files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting the final set of Java files in `room-runtime` from Java to Kotlin.
Change-Id: I96c25112c3ab32f8df71c1408c8006bdae1b3b7f

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelperFactory.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/SQLiteCopyOpenHelperTest.kt
M room/room-runtime/src/main/java/androidx/room/DatabaseConfiguration.kt
M room/room-runtime/src/main/java/androidx/room/EntityInsertionAdapter.kt
M room/room-runtime/src/main/java/androidx/room/EntityDeletionOrUpdateAdapter.kt
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/SharedSQLiteStatement.kt
M room/room-runtime/api/current.txt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/src/main/java/androidx/room/ExperimentalRoomApi.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/DelegatingOpenHelper.kt

https://android-review.googlesource.com/2065333

ap...@google.com <ap...@google.com> #8May 25, 2022 04:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3e34c01fd2679c1deb0d5ef4cdd76823f425a3ec
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:58:34 2022

Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting all RoomDatabase related files in `room-runtime` from Java to Kotlin.
Change-Id: Ie4b55827902c6ddcc4cc004de8bb5286823e9ab5

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/TransactionExecutor.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/RoomSQLiteQueryTest.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.kt
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-paging-guava/src/main/java/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-compiler/src/test/data/databasewriter/output/ComplexDatabase.java
M room/room-ktx/src/main/java/androidx/room/RoomDatabaseExt.kt
M room/room-runtime/src/main/java/androidx/room/RoomSQLiteQuery.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/RoomOpenHelper.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M development/build_log_simplifier/messages.ignore
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/SQLiteOpenHelperWriter.kt
M room/room-ktx/src/test/java/androidx/room/CoroutinesRoomTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/AlteredTableColumnOrderTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/SampleDatabaseService.java
M room/room-testing/src/main/java/androidx/room/testing/MigrationTestHelper.java
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt

https://android-review.googlesource.com/1961019

el...@google.com <el...@google.com> Jun 11, 2022 12:26AM

Marked as fixed.