Fixed
Status Update
Comments
de...@whsoft.de <de...@whsoft.de> #2
I have a similar issue when using android:inputType="numberDecimal" and android:digits="1234567890,."
In 1.3.1 it allowed only a single decimal separator. With 1.4.0 I can input multiple dots and commas.
Even if I set the keyListener to DigitsKeyListener.getInstance("0123456789") in afterTextChanged when the text contains a dot or comma, I can still enter dots and commas.
In 1.3.1 it allowed only a single decimal separator. With 1.4.0 I can input multiple dots and commas.
Even if I set the keyListener to DigitsKeyListener.getInstance("0123456789") in afterTextChanged when the text contains a dot or comma, I can still enter dots and commas.
al...@google.com <al...@google.com>
ad...@gmail.com <ad...@gmail.com> #3
I can cofirm the issue. We have a lot of crashes because of that change.
android:inputType="numberDecimal" stopped working and even if you set allowed digits there - user can type to inputDecimal field "_" "-", "+" - different signs that are showing up on the keyboard. It's not GBoard only issue, confirmed also on other keyboards.
android:inputType="numberDecimal" stopped working and even if you set allowed digits there - user can type to inputDecimal field "_" "-", "+" - different signs that are showing up on the keyboard. It's not GBoard only issue, confirmed also on other keyboards.
se...@google.com <se...@google.com> #4
Thanks for the report, I'll prioritize this for the next release.
se...@google.com <se...@google.com> #5
Also applies to "number" per
ma...@gmail.com <ma...@gmail.com> #6
I can also confirm that bug after update androidx.appcompat:appcompat to 1.4.0 version keyListener or android:digits in XML work unpredictably.
For example that code allow to write allow characters like ` ' ` or ` ` although they should be prohibited.
<androidx.appcompat.widget.AppCompatEditText
android:id="@+id/editText"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:digits="123456,."
android:inputType="number"
tools:hint="@tools:sample/lorem" />
A similar behavior is observed for set keyListener to eg. DigitsKeyListener.getInstance("123456")
For fast workaround i reverted to 1.3.1 version, but if you need this particular version until it will be fixed you can try override onCreateInputConnection.
For example that code allow to write allow characters like ` ' ` or ` ` although they should be prohibited.
<androidx.appcompat.widget.AppCompatEditText
android:id="@+id/editText"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:digits="123456,."
android:inputType="number"
tools:hint="@tools:sample/lorem" />
A similar behavior is observed for set keyListener to eg. DigitsKeyListener.getInstance("123456")
For fast workaround i reverted to 1.3.1 version, but if you need this particular version until it will be fixed you can try override onCreateInputConnection.
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit cc79ab23d84ed312bb81c2b873ec260dde762b3f
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 02 16:20:29 2021
Don't wrap NumberKeyListeners for emoji
All subclasses of NumberKeyListener do not allow emoji to be input, and
wrapping them breaks locale setting inside of TextView, which is visible
as a change in input filtering behavior.
Fixes: b/207119921
Relnote: "Fixes issue with all NumberKeyListener subclasses introduced
in appcompat 1.4.0 that allowed unexpected characters such as
punctuation to be input ( b/207119921 )"
Test: Manual & ./gradlew :appc:appc:cAT
Change-Id: Iede7af5e0599d29fd4cee78a798d5bcb07e1ab97
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M samples/Support7Demos/src/main/res/layout/appcompat_widgets_text_input.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
https://android-review.googlesource.com/1909341
Branch: androidx-main
commit cc79ab23d84ed312bb81c2b873ec260dde762b3f
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 02 16:20:29 2021
Don't wrap NumberKeyListeners for emoji
All subclasses of NumberKeyListener do not allow emoji to be input, and
wrapping them breaks locale setting inside of TextView, which is visible
as a change in input filtering behavior.
Fixes:
Relnote: "Fixes issue with all NumberKeyListener subclasses introduced
in appcompat 1.4.0 that allowed unexpected characters such as
punctuation to be input (
Test: Manual & ./gradlew :appc:appc:cAT
Change-Id: Iede7af5e0599d29fd4cee78a798d5bcb07e1ab97
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M samples/Support7Demos/src/main/res/layout/appcompat_widgets_text_input.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
se...@google.com <se...@google.com> #8
Thanks for reports, the problem is caused due to locale related code in TextView.
First CL here fixes XML, will also fix the setter path in another CL.
Thanks!
sa...@gmail.com <sa...@gmail.com> #9
but when it will be fixed. lots of users having issues.
[Deleted User] <[Deleted User]> #11
55subreiaderg. Goodiderg
[Deleted User] <[Deleted User]> #12
Anabgoodiosocrein riegaderg.goo55
Description
Build: AI-203.7717.56.2031.7784292, 202110010236,
AI-203.7717.56.2031.7784292, JRE 11.0.10+0-b96-7249189x64 JetBrains s.r.o., OS Linux(amd64) v5.4.0-90-generic, screens 1920.0x1080.0
AS: Arctic Fox | 2020.3.1 Patch 3; Kotlin plugin: 203-1.6.0-release-798-AS7717.8; Android Gradle Plugin: 7.0.3; Gradle: 7.0.2; Gradle JDK: version 11.0.10; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.20.2
IMPORTANT: Please read