androidx.appcompat:appcompat:1.4.0 broke Keyboard-EditText [207119921]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Nov 21, 2021 08:23AM

In my application I use EditText to accept only numbers. So in my layout file (.xml) I use like: android:inputType="number" android:digits="1234567890". This used to work for me until I updated to androidx.appcompat:appcompat:1.4.0. Due to this issue I switched back to androidx.appcompat:appcompat:1.3.1 which works fine.

Build: AI-203.7717.56.2031.7784292, 202110010236,

AI-203.7717.56.2031.7784292, JRE 11.0.10+0-b96-7249189x64 JetBrains s.r.o., OS Linux(amd64) v5.4.0-90-generic, screens 1920.0x1080.0

AS: Arctic Fox | 2020.3.1 Patch 3; Kotlin plugin: 203-1.6.0-release-798-AS7717.8; Android Gradle Plugin: 7.0.3; Gradle: 7.0.2; Gradle JDK: version 11.0.10; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.20.2

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

de...@whsoft.de <de...@whsoft.de> #2Nov 22, 2021 10:14AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

al...@google.com <al...@google.com> Nov 24, 2021 06:08PM

Assigned to se...@google.com.

ad...@gmail.com <ad...@gmail.com> #3Dec 1, 2021 02:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

se...@google.com <se...@google.com> #4Dec 2, 2021 10:27PM

deleted

se...@google.com <se...@google.com> #5Dec 2, 2021 10:29PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ma...@gmail.com <ma...@gmail.com> #6Dec 3, 2021 05:28PM

I can also confirm that bug after update androidx.appcompat:appcompat to 1.4.0 version keyListener or android:digits in XML work unpredictably.

For example that code allow to write allow characters like ` ' ` or ` ` although they should be prohibited.
<androidx.appcompat.widget.AppCompatEditText
android:id="@+id/editText"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:digits="123456,."
android:inputType="number"
tools:hint="@tools:sample/lorem" />

A similar behavior is observed for set keyListener to eg. DigitsKeyListener.getInstance("123456")

For fast workaround i reverted to 1.3.1 version, but if you need this particular version until it will be fixed you can try override onCreateInputConnection.

ap...@google.com <ap...@google.com> #7Dec 3, 2021 07:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit cc79ab23d84ed312bb81c2b873ec260dde762b3f
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 02 16:20:29 2021

Don't wrap NumberKeyListeners for emoji

All subclasses of NumberKeyListener do not allow emoji to be input, and
wrapping them breaks locale setting inside of TextView, which is visible
as a change in input filtering behavior.

Fixes:

b/207119921

Relnote: "Fixes issue with all NumberKeyListener subclasses introduced
in appcompat 1.4.0 that allowed unexpected characters such as
punctuation to be input (

b/207119921

)"
Test: Manual & ./gradlew :appc:appc:cAT

Change-Id: Iede7af5e0599d29fd4cee78a798d5bcb07e1ab97

M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M samples/Support7Demos/src/main/res/layout/appcompat_widgets_text_input.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java

https://android-review.googlesource.com/1909341

se...@google.com <se...@google.com> #8Dec 3, 2021 07:22PM

Thanks for reports, the problem is caused due to locale related code in TextView.

First CL here fixes XML, will also fix the setter path in another CL.

Thanks!

sa...@gmail.com <sa...@gmail.com> #9Jan 7, 2022 04:41AM

but when it will be fixed. lots of users having issues.

se...@google.com <se...@google.com> #10Jan 13, 2022 07:43PM

It is out in 1.4.1.

https://developer.android.com/jetpack/androidx/releases/appcompat#1.4.1

[Deleted User] <[Deleted User]> #11Dec 26, 2022 01:45PM

55subreiaderg. Goodiderg

[Deleted User] <[Deleted User]> #12Dec 26, 2022 01:46PM

Anabgoodiosocrein riegaderg.goo55