Fixed
Status Update
Comments
de...@whsoft.de <de...@whsoft.de> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
al...@google.com <al...@google.com>
ad...@gmail.com <ad...@gmail.com> #3
se...@google.com <se...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
se...@google.com <se...@google.com> #5
Also applies to "number" per
ma...@gmail.com <ma...@gmail.com> #6
I can also confirm that bug after update androidx.appcompat:appcompat to 1.4.0 version keyListener or android:digits in XML work unpredictably.
For example that code allow to write allow characters like ` ' ` or ` ` although they should be prohibited.
<androidx.appcompat.widget.AppCompatEditText
android:id="@+id/editText"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:digits="123456,."
android:inputType="number"
tools:hint="@tools:sample/lorem" />
A similar behavior is observed for set keyListener to eg. DigitsKeyListener.getInstance("123456")
For fast workaround i reverted to 1.3.1 version, but if you need this particular version until it will be fixed you can try override onCreateInputConnection.
For example that code allow to write allow characters like ` ' ` or ` ` although they should be prohibited.
<androidx.appcompat.widget.AppCompatEditText
android:id="@+id/editText"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:digits="123456,."
android:inputType="number"
tools:hint="@tools:sample/lorem" />
A similar behavior is observed for set keyListener to eg. DigitsKeyListener.getInstance("123456")
For fast workaround i reverted to 1.3.1 version, but if you need this particular version until it will be fixed you can try override onCreateInputConnection.
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit cc79ab23d84ed312bb81c2b873ec260dde762b3f
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 02 16:20:29 2021
Don't wrap NumberKeyListeners for emoji
All subclasses of NumberKeyListener do not allow emoji to be input, and
wrapping them breaks locale setting inside of TextView, which is visible
as a change in input filtering behavior.
Fixes: b/207119921
Relnote: "Fixes issue with all NumberKeyListener subclasses introduced
in appcompat 1.4.0 that allowed unexpected characters such as
punctuation to be input ( b/207119921 )"
Test: Manual & ./gradlew :appc:appc:cAT
Change-Id: Iede7af5e0599d29fd4cee78a798d5bcb07e1ab97
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M samples/Support7Demos/src/main/res/layout/appcompat_widgets_text_input.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
https://android-review.googlesource.com/1909341
Branch: androidx-main
commit cc79ab23d84ed312bb81c2b873ec260dde762b3f
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 02 16:20:29 2021
Don't wrap NumberKeyListeners for emoji
All subclasses of NumberKeyListener do not allow emoji to be input, and
wrapping them breaks locale setting inside of TextView, which is visible
as a change in input filtering behavior.
Fixes:
Relnote: "Fixes issue with all NumberKeyListener subclasses introduced
in appcompat 1.4.0 that allowed unexpected characters such as
punctuation to be input (
Test: Manual & ./gradlew :appc:appc:cAT
Change-Id: Iede7af5e0599d29fd4cee78a798d5bcb07e1ab97
M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M samples/Support7Demos/src/main/res/layout/appcompat_widgets_text_input.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java
se...@google.com <se...@google.com> #8
Thanks for reports, the problem is caused due to locale related code in TextView.
First CL here fixes XML, will also fix the setter path in another CL.
Thanks!
sa...@gmail.com <sa...@gmail.com> #9
but when it will be fixed. lots of users having issues.
[Deleted User] <[Deleted User]> #11
55subreiaderg. Goodiderg
[Deleted User] <[Deleted User]> #12
Anabgoodiosocrein riegaderg.goo55
Description
Build: AI-203.7717.56.2031.7784292, 202110010236,
AI-203.7717.56.2031.7784292, JRE 11.0.10+0-b96-7249189x64 JetBrains s.r.o., OS Linux(amd64) v5.4.0-90-generic, screens 1920.0x1080.0
AS: Arctic Fox | 2020.3.1 Patch 3; Kotlin plugin: 203-1.6.0-release-798-AS7717.8; Android Gradle Plugin: 7.0.3; Gradle: 7.0.2; Gradle JDK: version 11.0.10; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.20.2
IMPORTANT: Please read