IssueTracker

Component used: Navigation Version used: 2.4.0-beta02 Devices/Android versions reproduced on: multiple versions

When using fromSavedStateHandle to create the NavArgs class, it succeeds on first passes, but it fails when it tries to restore the data from the saved state (after process-death) if it has any Parcelable[] objects, as it doesn't cast them properly.

To reproduce this, please use the attached project, and enable "don't keep activities" from the developer options, if you open the app, then navigate to another app, and comes back, the app will crash with the following stacktrace:

    Process: com.hicham.navigationcrash, PID: 22769
    java.lang.RuntimeException: An exception happened in constructor of class com.hicham.navigationcrash.DestinationViewModel
        at androidx.lifecycle.SavedStateViewModelFactory.create(SavedStateViewModelFactory.java:132)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:185)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:150)
        ...
     Caused by: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to com.hicham.navigationcrash.CustomParcelable[]
        at com.hicham.navigationcrash.DestinationFragmentArgs$Companion.fromSavedStateHandle(DestinationFragmentArgs.kt:48)
        at com.hicham.navigationcrash.DestinationViewModel.<init>(DestinationViewModel.kt:8)
        ...

The generated fromSavedStateHandle from the attached project has this:

if (savedStateHandle.contains("custom")) {
        __custom = savedStateHandle["custom"]
        if (__custom == null) {
          throw IllegalArgumentException("Argument \"custom\" is marked as non-null but was passed a null value")
        }
      }

while fromBundle handles the casting properly:

if (bundle.containsKey("custom")) {
        __custom = bundle.getParcelableArray("custom")?.map { it as CustomParcelable
            }?.toTypedArray()
        if (__custom == null) {
          throw IllegalArgumentException("Argument \"custom\" is marked as non-null but was passed a null value.")
        }
      }