"fromSavedStateHandle" can't restore custom parcelable arrays properly [207315994]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

hi...@gmail.com

created issue #1

Nov 22, 2021 03:43PM

Component used: Navigation Version used: 2.4.0-beta02 Devices/Android versions reproduced on: multiple versions

When using fromSavedStateHandle to create the NavArgs class, it succeeds on first passes, but it fails when it tries to restore the data from the saved state (after process-death) if it has any Parcelable[] objects, as it doesn't cast them properly.

To reproduce this, please use the attached project, and enable "don't keep activities" from the developer options, if you open the app, then navigate to another app, and comes back, the app will crash with the following stacktrace:

    Process: com.hicham.navigationcrash, PID: 22769
    java.lang.RuntimeException: An exception happened in constructor of class com.hicham.navigationcrash.DestinationViewModel
        at androidx.lifecycle.SavedStateViewModelFactory.create(SavedStateViewModelFactory.java:132)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:185)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:150)
        ...
     Caused by: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to com.hicham.navigationcrash.CustomParcelable[]
        at com.hicham.navigationcrash.DestinationFragmentArgs$Companion.fromSavedStateHandle(DestinationFragmentArgs.kt:48)
        at com.hicham.navigationcrash.DestinationViewModel.<init>(DestinationViewModel.kt:8)
        ...

The generated fromSavedStateHandle from the attached project has this:

if (savedStateHandle.contains("custom")) {
        __custom = savedStateHandle["custom"]
        if (__custom == null) {
          throw IllegalArgumentException("Argument \"custom\" is marked as non-null but was passed a null value")
        }
      }

while fromBundle handles the casting properly:

if (bundle.containsKey("custom")) {
        __custom = bundle.getParcelableArray("custom")?.map { it as CustomParcelable
            }?.toTypedArray()
        if (__custom == null) {
          throw IllegalArgumentException("Argument \"custom\" is marked as non-null but was passed a null value.")
        }
      }

NavigationCrash.zip

427 KB

Download

Comments

il...@google.com <il...@google.com> Nov 29, 2021 05:14PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Dec 3, 2021 11:38PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

jb...@google.com <jb...@google.com> #3Dec 4, 2021 12:17AM

Marked as fixed.

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

[Deleted User] <[Deleted User]> #4Dec 5, 2022 01:15PM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

il...@google.com <il...@google.com> #5Dec 5, 2022 03:37PM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

Issue 207315994