IssueTracker

Component used: Navigation
Version used: 2.4.0-beta02
Devices/Android versions reproduced on: Emulator API 23 and 31

Describe the problem:

When navigating to a composable dialog destination, the dialog destination is lost after an orientation change.

Observed Results:

The composable dialog destination is lost after an orientation change

Expected Results:

The composable dialog destination should still be visible after an orientation change

Steps to reproduce:

1. Clone the reproduction project https://github.com/leinardi/Forlago/tree/dialog and checkout the branch dialog
2. Run the app
3. Tap on the button "Show Dialog"
4. Trigger an orientation change rotating the device

Relevant Code:

The composable dialog is defined here: https://github.com/leinardi/Forlago/blob/dialog/modules/feature-foo/src/main/kotlin/com/leinardi/forlago/feature/foo/ui/foodialog/FooDialogScreen.kt#L36

The Dialog destination route is defined here: https://github.com/leinardi/Forlago/blob/dialog/modules/core-navigation/src/main/kotlin/com/leinardi/forlago/core/navigation/destination/foo/FooDialogDestination.kt#L22

The Dialog destinations are added to the NavHost here: https://github.com/leinardi/Forlago/blob/dialog/app/src/main/kotlin/com/leinardi/forlago/ui/MainActivity.kt#L109

Attached there is a short video showing the issue.